Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11416336: Revert an occasional change of Trap to UnsafeTrap (Closed)

Created:
8 years ago by Alexander Potapenko
Modified:
8 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jln+watch_chromium.org
Visibility:
Public.

Description

Revert an occasional change of Trap to UnsafeTrap BUG=127536 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170894

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/common/sandbox_seccomp_bpf_linux.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alexander Potapenko
Please take a look
8 years ago (2012-12-04 06:27:36 UTC) #1
Jorge Lucangeli Obes
lgtm It's good that you could use greylisting for debugging though ;-) thanks for the ...
8 years ago (2012-12-04 06:30:46 UTC) #2
jln (very slow on Chromium)
lgtm. I've set NOTRY=true and I'll send it to the CQ.
8 years ago (2012-12-04 06:31:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/11416336/1
8 years ago (2012-12-04 06:31:46 UTC) #4
commit-bot: I haz the power
8 years ago (2012-12-04 06:31:54 UTC) #5
Message was sent while issue was closed. 
Change committed as 170894

Powered by Google App Engine
This is Rietveld 408576698