Issue 11416322: [Android] Fix "remove" and "remove all" usage on NTP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11416322: [Android] Fix "remove" and "remove all" usage on NTP. (Closed)

Created:
8 years ago by newt (away)

Modified:
8 years ago

Reviewers:
Ted C, Evan Stade

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews), pedrosimonetti+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[Android] Fix "remove" and "remove all" usage on NTP. Use "Remove all" for the recently closed tabs list, and "Remove" for all other lists. BUG=163944 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171050

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -2 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/resources/ntp_android/ntp_android.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

newt (away)

+estade as owner for chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc PTAL

8 years ago (2012-12-04 04:47:51 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/11416322/1

8 years ago (2012-12-04 18:04:13 UTC) #5

Message was sent while issue was closed.

Change committed as 171050