Issue 11416309: Fix constrained window position for inactive tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11416309: Fix constrained window position for inactive tab (Closed)

Created:
8 years ago by sail

Modified:
8 years ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix constrained window position for inactive tab If a constrained window was added to an inactive tab it would be incorrectly positioned. The problem was that an inactive tab view is removed from the browser window. This meant that the constrained window position coudln't be calculated. When the tab became activated again we weren't updating the sheet position. This CL changes the code to correclty update the sheet position when the tab is activated. BUG=163841 TEST=Verified that the bug can no longer be reproduced. Verified that ConstrainedWindowSheetControllerTest.AddToInactiveTab failed without my change and passes with it. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170782

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -15 lines)			Patch
	M	chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.mm	View		2 chunks	+8 lines, -4 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller_unittest.mm	View		5 chunks	+12 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/11416309/1

8 years ago (2012-12-03 16:28:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/11416309/1

8 years ago (2012-12-03 18:53:10 UTC) #4

Message was sent while issue was closed.

Change committed as 170782

Expand Messages | Collapse Messages