Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 11416285: Omnibiox: Tweak HQP New Scoring and Re-Enable Field Trial (Closed)

Created:
8 years ago by Mark P
Modified:
8 years ago
Reviewers:
Peter Kasting, sky
CC:
chromium-reviews, James Su, browser-components-watch_chromium.org
Visibility:
Public.

Description

Omnibiox: Tweak HQP New Scoring and Re-Enable Field Trial Tweaks HQP "new scoring" by (1) By a smooth squash, prevent HQP from scoring above 1400. This makes sure inlineable, high-quality, prefix matches (whether scored by HUP or by the HUP-like mode in HQP), which has scores in the 1400-1410 range, are not trumped. (2) Remove any credit for mid-word matches in titles. I decided spacing in titles should always make sense and allowing mid-word matches here seems wrong. Also, I changed the name of the "new scoring" field trial as well so we can distinguish the new behavior trial from the old behavior trial. This trial is set up independent of the "old scoring" ignore-all-mid-word-matches field trial. I prefer it this way because then I can easily enable or disable one without having to change much code. Will analyze them in a dependent/correlated fashion--that is, I will only look at this trial when in the control group of the ignore-mid-word-matches trial and will only analyze the mid-word-matches trial when in the control group of this trial. BUG=161911 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170869

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix spacing in header file. #

Patch Set 3 : Fix unit test. #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -21 lines) Patch
M chrome/browser/autocomplete/autocomplete_field_trial.cc View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/history/scored_history_match.h View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/history/scored_history_match.cc View 1 2 3 3 chunks +28 lines, -9 lines 0 comments Download
M chrome/browser/history/scored_history_match_unittest.cc View 1 2 3 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Mark P
Hi Peter, When it rains field trials, it pours. I thought more about the results ...
8 years ago (2012-11-30 19:07:33 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/11416285/diff/1/chrome/browser/history/scored_history_match.h File chrome/browser/history/scored_history_match.h (right): https://codereview.chromium.org/11416285/diff/1/chrome/browser/history/scored_history_match.h#newcode104 chrome/browser/history/scored_history_match.h:104: float topicality_score, float recency_score, float popularity_score); Nit: One ...
8 years ago (2012-12-01 02:45:30 UTC) #2
Mark P
https://codereview.chromium.org/11416285/diff/1/chrome/browser/history/scored_history_match.h File chrome/browser/history/scored_history_match.h (right): https://codereview.chromium.org/11416285/diff/1/chrome/browser/history/scored_history_match.h#newcode104 chrome/browser/history/scored_history_match.h:104: float topicality_score, float recency_score, float popularity_score); On 2012/12/01 02:45:30, ...
8 years ago (2012-12-01 22:27:06 UTC) #3
Mark P
Scott, Can you get your OWNERS stamp on this changelist (as well as the other ...
8 years ago (2012-12-01 22:27:54 UTC) #4
sky
LGTM
8 years ago (2012-12-03 15:46:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/11416285/5001
8 years ago (2012-12-03 17:14:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/11416285/12002
8 years ago (2012-12-03 18:52:56 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-03 22:08:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/11416285/7008
8 years ago (2012-12-03 22:28:41 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-12-03 22:38:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/11416285/7008
8 years ago (2012-12-03 22:48:31 UTC) #11
commit-bot: I haz the power
8 years ago (2012-12-04 02:57:03 UTC) #12
Message was sent while issue was closed.
Change committed as 170869

Powered by Google App Engine
This is Rietveld 408576698