Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 11416279: Return AUTHENTICATION_FAILED error if Drive operation has failed and user is not signed in (Closed)

Created:
8 years ago by kinuko
Modified:
8 years ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

Return AUTHENTICATION_FAILED error if Drive operation has failed and user is not signed in BUG=163548 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170554

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -11 lines) Patch
M chrome/browser/sync_file_system/drive_file_sync_service.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service.cc View 11 chunks +22 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinuko
PTL. (drive_file_sync_client.h changes are from https://codereview.chromium.org/11316266/, I'll rebase once it's landed)
8 years ago (2012-11-30 08:22:26 UTC) #1
nhiroki
lgtm
8 years ago (2012-11-30 08:58:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/11416279/3002
8 years ago (2012-11-30 19:41:50 UTC) #3
commit-bot: I haz the power
8 years ago (2012-11-30 21:38:13 UTC) #4
Message was sent while issue was closed.
Change committed as 170554

Powered by Google App Engine
This is Rietveld 408576698