Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 11416265: Linux: include system Mesa headers when using system Mesa. (Closed)

Created:
8 years ago by Paweł Hajdan Jr.
Modified:
8 years ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: include system Mesa headers when using system Mesa. BUG=161389 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170390

Patch Set 1 #

Patch Set 2 : shim header #

Patch Set 3 : fix compile #

Patch Set 4 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -9 lines) Patch
A third_party/mesa/include/osmesa.h View 1 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/mesa/mesa.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/gl/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_glx.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_linux.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_mac.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_surface_glx.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_surface_linux.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_surface_mac.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_surface_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Paweł Hajdan Jr.
8 years ago (2012-11-29 19:06:22 UTC) #1
apatrick_chromium
How about adding a new header file, not sure where, maybe ui/gl, that contains this: ...
8 years ago (2012-11-29 19:41:48 UTC) #2
Paweł Hajdan Jr.
Sounds good, PTAL.
8 years ago (2012-11-29 20:57:18 UTC) #3
apatrick_chromium
lgtm
8 years ago (2012-11-29 21:51:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/11416265/7
8 years ago (2012-11-29 22:07:53 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-11-29 22:22:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/11416265/9002
8 years ago (2012-11-30 00:14:58 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) nacl_integration
8 years ago (2012-11-30 01:23:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/11416265/9002
8 years ago (2012-11-30 01:28:02 UTC) #9
commit-bot: I haz the power
8 years ago (2012-11-30 03:55:23 UTC) #10
Message was sent while issue was closed.
Change committed as 170390

Powered by Google App Engine
This is Rietveld 408576698