Change UpdateProperties to UpdateProperty

Change UpdateProperties to UpdateProperty


BUG=163111
TEST=ran chromeos_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170490

[satorux1, 2012-11-28 23:13:16]

https://codereview.chromium.org/11416243/diff/1/chromeos/dbus/ibus/ibus_panel...
File chromeos/dbus/ibus/ibus_panel_service.cc (right):

https://codereview.chromium.org/11416243/diff/1/chromeos/dbus/ibus/ibus_panel...
chromeos/dbus/ibus/ibus_panel_service.cc:288: scoped_ptr<dbus::Response>
response(
I think this is wrong The Response is deleted in exported_object.cc:

void ExportedObject::OnMethodCompleted(MethodCall* method_call,
                                       Response* response,
                                       base::TimeTicks start_time) {
  bus_->AssertOnDBusThread();
  scoped_ptr<MethodCall> method_call_deleter(method_call);
  scoped_ptr<Response> response_deleter(response);


The ownership about the response object is unclear, as the d-bus code was
written before scoped_ptr<>::Pass() was introduced...

We should at least add more comments in exported_object.h. about ownership.

[Seigo Nonaka, 2012-11-29 07:50:48]

Sorry, I don't have any idea for memory leak now.
So let me split the CL.

Thanks

https://codereview.chromium.org/11416243/diff/1/chromeos/dbus/ibus/ibus_panel...
File chromeos/dbus/ibus/ibus_panel_service.cc (right):

https://codereview.chromium.org/11416243/diff/1/chromeos/dbus/ibus/ibus_panel...
chromeos/dbus/ibus/ibus_panel_service.cc:288: scoped_ptr<dbus::Response>
response(
On 2012/11/28 23:13:16, satorux1 wrote:
> I think this is wrong The Response is deleted in exported_object.cc:
> 
> void ExportedObject::OnMethodCompleted(MethodCall* method_call,
>                                        Response* response,
>                                        base::TimeTicks start_time) {
>   bus_->AssertOnDBusThread();
>   scoped_ptr<MethodCall> method_call_deleter(method_call);
>   scoped_ptr<Response> response_deleter(response);
> 
> 
> The ownership about the response object is unclear, as the d-bus code was
> written before scoped_ptr<>::Pass() was introduced...
> 
> We should at least add more comments in exported_object.h. about ownership.

Done.

[satorux1, 2012-11-30 05:29:00]

LGTM

[commit-bot: I haz the power, 2012-11-30 16:40:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/11416243/7001

[commit-bot: I haz the power, 2012-11-30 18:33:03]

Change committed as 170490