Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 11416239: Fix tautological compares in font_atlas.cc. (Closed)

Created:
8 years ago by hans
Modified:
8 years ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Fix tautological compares in font_atlas.cc. This fixes the following warnings from a recent version of Clang: cc/font_atlas.cc:62:43: error: comparison of constant 128 with expression of type 'char' is always true [-Werror,-Wtautological-constant-out-of-range-compare] cc/font_atlas.cc:45:39: error: comparison of constant 128 with expression of type 'const char' is always true [-Werror,-Wtautological-constant-out-of-range-compare] The problem is that the char type is signed on this platform, and therefore always < 128. The code really wants to work with the unsigned values here. BUG=163104 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170041

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M cc/font_atlas.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hans
8 years ago (2012-11-28 13:28:54 UTC) #1
jamesr
lgtm
8 years ago (2012-11-28 17:48:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/11416239/1
8 years ago (2012-11-28 18:00:41 UTC) #3
commit-bot: I haz the power
8 years ago (2012-11-28 20:33:02 UTC) #4
Message was sent while issue was closed.
Change committed as 170041

Powered by Google App Engine
This is Rietveld 408576698