Add support to Pickle for reading and writing floats

Add support to Pickle for reading and writing floats

BUG=136034
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169957

[Rick Byers, 2012-11-22 00:25:43]

Hey Jim,
Can you please review this little Pickle addition please?  I need to be able to
serialize floats because I'll be adding one to WebCursor which currently needs
manual IPC serialization.

At first I was concerned that float was intentionally omitted as not being
stable enough, but it looks like we aren't concerned with cross-platform
interoperability (eg. byte-order differences between arm and x86), and
regardless basically every GCC target uses the same 32-bit representation for
floats (IEEE 754).

Thanks,
   Rick

[jar (doing other things), 2012-11-23 19:18:51]

I think this LGTM

I have a vague recollection about having to interact with some other binary....
perhaps on the try bots... build bots... or installer. 

I've added Carlos and Ricardo in case they recall any additional constraints.

[rvargas (doing something else), 2012-11-26 20:25:25]

On 2012/11/23 19:18:51, jar wrote:
> I think this LGTM
> 
> I have a vague recollection about having to interact with some other
binary....
> perhaps on the try bots... build bots... or installer.

You may be thinking about the perf bots (where we have some IPC issues with an
older version that we run for baseline).

That is to say, as far as I know we don't have requirements for passing pickled
data across machines, much less CPU architectures (but we do read pickles from
disk).

(so LGTM too).

> 
> I've added Carlos and Ricardo in case they recall any additional constraints.

[Rick Byers, 2012-11-26 20:29:16]

On 2012/11/26 20:25:25, rvargas wrote:
> On 2012/11/23 19:18:51, jar wrote:
> > I think this LGTM
> > 
> > I have a vague recollection about having to interact with some other
> binary....
> > perhaps on the try bots... build bots... or installer.
> 
> You may be thinking about the perf bots (where we have some IPC issues with an
> older version that we run for baseline).
> 
> That is to say, as far as I know we don't have requirements for passing
pickled
> data across machines, much less CPU architectures (but we do read pickles from
> disk).
> 
> (so LGTM too).
> 
> > 
> > I've added Carlos and Ricardo in case they recall any additional
constraints.

Thanks!

[commit-bot: I haz the power, 2012-11-26 20:29:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rbyers@chromium.org/11416150/8002

[commit-bot: I haz the power, 2012-11-27 21:02:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rbyers@chromium.org/11416150/8002

[commit-bot: I haz the power, 2012-11-28 15:11:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rbyers@chromium.org/11416150/8002

[commit-bot: I haz the power, 2012-11-28 15:41:00]

Change committed as 169957