Issue 11416075: fix GpuFeatureTest.RafNoDamage on win aura, mesa path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11416075: fix GpuFeatureTest.RafNoDamage on win aura, mesa path (Closed)

Created:
8 years, 1 month ago by scottmg

Modified:
8 years, 1 month ago

Reviewers:
piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ImageTransportSurface::CreateSurface on Windows handles the following cases: 1. content area on regular (non-aura) windows on vista+ 2. content area on regular (non-aura) windows on xp 3. content area on aura 4. top level compositor on aura on windows on angle (normal) 5. top level compositor on aura on windows on mesa (tests) And, the TransportSurface methods that should be used: 1. PbufferImageTransportSurface 2. NativeGLSurface (PassThroughImageTransportSurface) with transport=true 3. TextureImageTransportSurface 4. PbufferImageTransportSurface 5. NativeGLSurface (PassThroughImageTransportSurface) with transport=false This change fixes case #5. TEST=browser_tests, GpuFeatureTest.NoRafDamage Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168675

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -7 lines)			Patch
	M	content/browser/renderer_host/image_transport_factory.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download
	M	content/common/gpu/image_transport_surface_win.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11416075/8

8 years, 1 month ago (2012-11-19 22:47:03 UTC) #3

Change committed as 168675

Expand Messages | Collapse Messages

Issue 11416075: fix GpuFeatureTest.RafNoDamage on win aura, mesa path (Closed)

Description

Patch Set 1 #

Patch Set 2 : remove debugging code #

Patch Set 3 : launch code #

Messages