Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2502)

Unified Diff: content/renderer/browser_plugin/browser_plugin_manager_impl.h

Issue 11416074: Browser Plugin: Simplified BrowserPluginManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed nits Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin_manager_impl.h
diff --git a/content/renderer/browser_plugin/browser_plugin_manager_impl.h b/content/renderer/browser_plugin/browser_plugin_manager_impl.h
index 73d7c3b1ddf1cfb2c2d86902c2ead1c6a09c49ae..b472e5748f3ee39faeb41fd98fefc1b5f2a8f961 100644
--- a/content/renderer/browser_plugin/browser_plugin_manager_impl.h
+++ b/content/renderer/browser_plugin/browser_plugin_manager_impl.h
@@ -20,8 +20,7 @@ namespace content {
class BrowserPluginManagerImpl : public BrowserPluginManager {
public:
- BrowserPluginManagerImpl();
- virtual ~BrowserPluginManagerImpl();
+ BrowserPluginManagerImpl(RenderViewImpl* render_view);
// BrowserPluginManager implementation.
virtual BrowserPlugin* CreateBrowserPlugin(
@@ -32,9 +31,11 @@ class BrowserPluginManagerImpl : public BrowserPluginManager {
// IPC::Sender implementation.
virtual bool Send(IPC::Message* msg) OVERRIDE;
- // RenderProcessObserver override. Call on render thread.
- virtual bool OnControlMessageReceived(const IPC::Message& message) OVERRIDE;
+ // RenderViewObserver override. Call on render thread.
+ virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
private:
+ virtual ~BrowserPluginManagerImpl();
+
void OnUpdateRect(int instance_id,
int message_id,
const BrowserPluginMsg_UpdateRect_Params& params);
@@ -58,8 +59,7 @@ class BrowserPluginManagerImpl : public BrowserPluginManager {
bool is_top_level);
void OnSetCursor(int instance_id,
const WebCursor& cursor);
- void OnPluginAtPositionRequest(int source_routing_id,
- int request_id,
+ void OnPluginAtPositionRequest(int request_id,
const gfx::Point& position);
DISALLOW_COPY_AND_ASSIGN(BrowserPluginManagerImpl);

Powered by Google App Engine
This is Rietveld 408576698