Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 11416074: Browser Plugin: Simplified BrowserPluginManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed nits Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_renderer.gypi ('k') | content/renderer/browser_plugin/browser_plugin.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/browser_plugin/browser_plugin.h
diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h
index 6abd3e2d7f054ee81f80684f232923583ffcb555..caf1c2879f69c5b79ea599639b859785012e5623 100644
--- a/content/renderer/browser_plugin/browser_plugin.h
+++ b/content/renderer/browser_plugin/browser_plugin.h
@@ -203,6 +203,9 @@ class CONTENT_EXPORT BrowserPlugin :
int height() const { return plugin_rect_.height(); }
int instance_id() const { return instance_id_; }
int render_view_routing_id() const { return render_view_routing_id_; }
+ BrowserPluginManager* browser_plugin_manager() const {
+ return browser_plugin_manager_;
+ }
// Virtual to allow for mocking in tests.
virtual float GetDeviceScaleFactor() const;
@@ -290,6 +293,11 @@ class CONTENT_EXPORT BrowserPlugin :
gfx::Size last_view_size_;
bool size_changed_in_flight_;
+ // BrowserPlugin outlives RenderViewImpl in Chrome Apps and so we need to
+ // store the BrowserPlugin's BrowserPluginManager in a member variable to
+ // avoid accessing the RenderViewImpl.
+ scoped_refptr<BrowserPluginManager> browser_plugin_manager_;
+
// Important: Do not add more history state here.
// We strongly discourage storing additional history state (such as page IDs)
// in the embedder process, at the risk of having incorrect information that
« no previous file with comments | « content/content_renderer.gypi ('k') | content/renderer/browser_plugin/browser_plugin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698