Issue 11415293: Refactor access to scroll deltas in GesturePoint

Issue 11415293: Refactor access to scroll deltas in GesturePoint (Closed)

Created:
8 years ago by rjkroege

Modified:
8 years ago

Reviewers:
sadrul

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refactor access to scroll deltas in GesturePoint Clean up some code in the GesturePoint to provide centralized access to the scroll deltas so that smoothing of scroll start is easier to implement. BUG=141653 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171116

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -39 lines)			Patch
M	ui/aura/gestures/gesture_recognizer_unittest.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	ui/base/gestures/gesture_point.h	View		2 chunks	+5 lines, -9 lines	0 comments	Download
M	ui/base/gestures/gesture_point.cc	View		6 chunks	+21 lines, -18 lines	0 comments	Download
M	ui/base/gestures/gesture_sequence.cc	View	1	1 chunk	+7 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sadrul

LGTM The misuse of |first_*| in GesturePoint was confusing. Thanks for the cleanup. https://codereview.chromium.org/11415293/diff/1/ui/base/gestures/gesture_sequence.cc File ...

8 years ago (2012-12-04 21:27:44 UTC) #2

rjkroege

https://codereview.chromium.org/11415293/diff/1/ui/base/gestures/gesture_sequence.cc File ui/base/gestures/gesture_sequence.cc (right): https://codereview.chromium.org/11415293/diff/1/ui/base/gestures/gesture_sequence.cc#newcode750 ui/base/gestures/gesture_sequence.cc:750: if (d == gfx::Vector2d()) On 2012/12/04 21:27:44, sadrul wrote: ...

8 years ago (2012-12-04 21:53:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/11415293/4001

8 years ago (2012-12-04 21:53:49 UTC) #4

Message was sent while issue was closed.

Change committed as 171116

Expand Messages | Collapse Messages