Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: chrome/browser/sessions/session_types.cc

Issue 11415292: [Search] No longer reverting omnibox text on instant search (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: session_types comment Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sessions/session_types.cc
diff --git a/chrome/browser/sessions/session_types.cc b/chrome/browser/sessions/session_types.cc
index 59afc341fdb9604100636d2befdc8f85c738cddf..f91780ab2bfd5ae59246155471afe7c3c7b37886 100644
--- a/chrome/browser/sessions/session_types.cc
+++ b/chrome/browser/sessions/session_types.cc
@@ -48,6 +48,7 @@ TabNavigation TabNavigation::FromNavigationEntry(
navigation.original_request_url_ = entry.GetOriginalRequestURL();
navigation.is_overriding_user_agent_ = entry.GetIsOverridingUserAgent();
navigation.timestamp_ = entry.GetTimestamp();
+ navigation.search_terms_ = entry.GetSearchTerms();
return navigation;
}
@@ -133,6 +134,8 @@ TabNavigation TabNavigation::FromSyncData(
navigation.timestamp_ = base::Time();
+ navigation.search_terms_ = UTF8ToUTF16(sync_data.search_terms());
+
return navigation;
}
@@ -201,6 +204,7 @@ enum TypeMask {
// original_request_url_
// is_overriding_user_agent_
// timestamp_
+// search_terms_
void TabNavigation::WriteToPickle(Pickle* pickle) const {
pickle->WriteInt(index_);
@@ -245,6 +249,8 @@ void TabNavigation::WriteToPickle(Pickle* pickle) const {
original_request_url_.spec() : std::string());
pickle->WriteBool(is_overriding_user_agent_);
pickle->WriteInt64(timestamp_.ToInternalValue());
+
+ WriteString16ToPickle(pickle, &bytes_written, max_state_size, search_terms_);
}
bool TabNavigation::ReadFromPickle(PickleIterator* iterator) {
@@ -298,6 +304,11 @@ bool TabNavigation::ReadFromPickle(PickleIterator* iterator) {
} else {
timestamp_ = base::Time();
}
+
+ // If the search terms field can't be found, leave it empty.
+ if (!iterator->ReadString16(&search_terms_)) {
+ search_terms_ = string16();
+ }
}
return true;
@@ -326,6 +337,7 @@ scoped_ptr<NavigationEntry> TabNavigation::ToNavigationEntry(
entry->SetOriginalRequestURL(original_request_url_);
entry->SetIsOverridingUserAgent(is_overriding_user_agent_);
entry->SetTimestamp(timestamp_);
+ entry->SetSearchTerms(search_terms_);
return entry.Pass();
}
@@ -418,6 +430,8 @@ sync_pb::TabNavigation TabNavigation::ToSyncData() const {
// The full-resolution timestamp works as a global ID.
sync_data.set_global_id(timestamp_.ToInternalValue());
+ sync_data.set_search_terms(UTF16ToUTF8(search_terms_));
+
return sync_data;
}

Powered by Google App Engine
This is Rietveld 408576698