Refactored analysis into a build participant

Refactored analysis into a build participant
Committed: https://code.google.com/p/dart/source/detail?r=15625

[danrubel, 2012-12-02 22:55:57]

- moved existing analysis from DartBuilder into new build participant
- added new analysis build participant that uses AnalysisEngine (behind flag)
- new experimental/analysis/engine option

[Brian Wilkerson, 2012-12-03 03:52:23]

LGTM

https://codereview.chromium.org/11415253/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisEngineParticipant.java
(right):

https://codereview.chromium.org/11415253/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisEngineParticipant.java:65:
factory = new SourceFactory(new FileUriResolver());
We will also want to create and pass in instances of DartUriResover and
PackageUriResolver.

https://codereview.chromium.org/11415253/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisEngineParticipant.java:66:
context = AnalysisEngine.getInstance().createAnalysisContext();
Add "context.setSourceFactory(factory);"

https://codereview.chromium.org/11415253/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisEngineParticipant.java:88:
event.getProject().deleteMarkers(DartCore.DART_PROBLEM_MARKER_TYPE, true,
DEPTH_INFINITE);
Probably want to re-create the analysis context at this point.

https://codereview.chromium.org/11415253/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisEngineParticipant.java:141:
// TODO (danrubel): calculate line number
The information you need for this is computed by the scanner. We might want to
cache the information for later use.

[danrubel, 2012-12-03 05:52:37]

https://codereview.chromium.org/11415253/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisEngineParticipant.java
(right):

https://codereview.chromium.org/11415253/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisEngineParticipant.java:65:
factory = new SourceFactory(new FileUriResolver());
On 2012/12/03 03:52:23, Brian Wilkerson wrote:
> We will also want to create and pass in instances of DartUriResover and
> PackageUriResolver.

Done.

https://codereview.chromium.org/11415253/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisEngineParticipant.java:66:
context = AnalysisEngine.getInstance().createAnalysisContext();
On 2012/12/03 03:52:23, Brian Wilkerson wrote:
> Add "context.setSourceFactory(factory);"

Done.

https://codereview.chromium.org/11415253/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisEngineParticipant.java:88:
event.getProject().deleteMarkers(DartCore.DART_PROBLEM_MARKER_TYPE, true,
DEPTH_INFINITE);
On 2012/12/03 03:52:23, Brian Wilkerson wrote:
> Probably want to re-create the analysis context at this point.

Done.

[devoncarew, 2012-12-03 14:33:49]

lgtm