Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4090)

Unified Diff: chrome/browser/ui/webui/options/certificate_manager_handler.cc

Issue 11415226: webui/options: Do not use Value::CreateStringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix typo Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/certificate_manager_handler.cc
diff --git a/chrome/browser/ui/webui/options/certificate_manager_handler.cc b/chrome/browser/ui/webui/options/certificate_manager_handler.cc
index 18ee17e0dd25e1fe9c3fa1ce0915d438aed4e630..a02e5f98e545200a43a9af5e3cc4bca8a4f062c3 100644
--- a/chrome/browser/ui/webui/options/certificate_manager_handler.cc
+++ b/chrome/browser/ui/webui/options/certificate_manager_handler.cc
@@ -1014,7 +1014,7 @@ void CertificateManagerHandler::PopulateTree(const std::string& tab_name,
std::sort(nodes->begin(), nodes->end(), comparator);
ListValue args;
- args.Append(Value::CreateStringValue(tree_name));
+ args.Append(new base::StringValue(tree_name));
args.Append(nodes);
web_ui()->CallJavascriptFunction("CertificateManager.onPopulateTree", args);
}
@@ -1023,9 +1023,9 @@ void CertificateManagerHandler::PopulateTree(const std::string& tab_name,
void CertificateManagerHandler::ShowError(const std::string& title,
const std::string& error) const {
ScopedVector<const Value> args;
- args.push_back(Value::CreateStringValue(title));
- args.push_back(Value::CreateStringValue(error));
- args.push_back(Value::CreateStringValue(l10n_util::GetStringUTF8(IDS_OK)));
+ args.push_back(new base::StringValue(title));
+ args.push_back(new base::StringValue(error));
+ args.push_back(new base::StringValue(l10n_util::GetStringUTF8(IDS_OK)));
args.push_back(Value::CreateNullValue()); // cancelTitle
args.push_back(Value::CreateNullValue()); // okCallback
args.push_back(Value::CreateNullValue()); // cancelCallback

Powered by Google App Engine
This is Rietveld 408576698