Add support for autofilling radio buttons and checkboxes.

chrome/browser/autofill/form_field_unittest.cc

Index: chrome/browser/autofill/form_field_unittest.cc
diff --git a/chrome/browser/autofill/form_field_unittest.cc b/chrome/browser/autofill/form_field_unittest.cc
index 16b51a0c83b3968afe91add1751578b1c6528946..55175900e76e53522fd8e22c095ea1bd256d8b53 100644
--- a/chrome/browser/autofill/form_field_unittest.cc
+++ b/chrome/browser/autofill/form_field_unittest.cc
@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/memory/scoped_vector.h"
 #include "base/string16.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/autofill_field.h"
@@ -114,3 +115,35 @@ TEST(FormFieldTest, Match) {
   EXPECT_FALSE(FormField::Match(&field, ASCIIToUTF16("\\bcr\\b"),
                                 FormField::MATCH_LABEL));
 }
+
+AutofillField* BuildTestField(const std::string& name) {

[Ilya Sherman, 2012/12/18 02:05:11]

nit: Please rename the parameter to |label|, since that's how you're using it.

+  FormFieldData field_data;
+  field_data.label = ASCIIToUTF16(name);
+  field_data.name = ASCIIToUTF16("name");
+  field_data.value = ASCIIToUTF16("value");
+  field_data.form_control_type = "text";
+  field_data.is_focusable = true;
+  field_data.autocomplete_attribute = "on";
+  field_data.should_autocomplete = true;
+  return new AutofillField(field_data, field_data.label);

[Ilya Sherman, 2012/12/18 02:05:11]

You should pretty much never return a raw pointer to heap-allocated memory, as
this is a recipe for leaks.  Instead, you can:

(a) Return a scoped_ptr<AutofillField>
(b) Pass in a pointer to an already allocated AutofillField, that this function
fills in.
(c) Return, by copy, a FormFieldData object, and construct the AutofillField
within the body of the test function.

+}

[Ilya Sherman, 2012/12/18 02:05:11]

nit: Please move this function definition into an anonymous namespace at the top
of this file.

+
+// Test that we ignore checkable elements.
+TEST(FormFieldTest, ParseFormFields) {
+  ScopedVector<AutofillField> fields;
+  fields.push_back(BuildTestField("Address line1"));
+  AutofillField* checkable_field = BuildTestField("Is PO box");
+  checkable_field->is_checkable = true;
+  fields.push_back(checkable_field);
+  fields.push_back(BuildTestField("Address line2"));
+
+  FieldTypeMap field_type_map;
+  FormField::ParseFormFields(fields.get(), &field_type_map);
+  // Checkable element shouldn't interfere with inference of Address line2.
+  EXPECT_EQ(2U, field_type_map.size());
+
+  EXPECT_EQ(ADDRESS_HOME_LINE1,
+            field_type_map.find(ASCIIToUTF16("Address line1"))->second);
+  EXPECT_EQ(ADDRESS_HOME_LINE2,
+            field_type_map.find(ASCIIToUTF16("Address line2"))->second);
+}