Add support for autofilling radio buttons and checkboxes.

chrome/browser/autofill/form_field.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/form_field.h"
 
 #include <stddef.h>
 #include <string>
 #include <utility>
 
@@ skipping 27 matching lines @@
 }
 
 bool IsTelephoneField(const std::string& type) {
   return type == "tel";
 }
 
 bool IsSelectField(const std::string& type) {
   return type == "select-one";
 }
 
+bool IsCheckable(const AutofillField* field) {
+  return field->is_checkable;
+}
+
 }  // namespace
 
 // static
 void FormField::ParseFormFields(const std::vector<AutofillField*>& fields,
                                 FieldTypeMap* map) {
   // Set up a working copy of the fields to be processed.
   std::vector<const AutofillField*> remaining_fields(fields.size());
   std::copy(fields.begin(), fields.end(), remaining_fields.begin());
 
+  // Ignore checkable fields as they interfere with parsers assuming context.
+  // Eg., while parsing address, "Is PO box" checkbox after ADDRESS_LINE1
+  // interferes with correctly understanding ADDRESS_LINE2.
+  remaining_fields.erase(
+      remove_if(remaining_fields.begin(), remaining_fields.end(), IsCheckable),
+      remaining_fields.end());

[Ilya Sherman, 2012/12/17 22:33:27]

Please add test coverage for this.

[Raman Kakilate, 2012/12/18 01:54:04]

Done.

+
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
   bool parse_new_field_types =
       command_line.HasSwitch(switches::kEnableNewAutofillHeuristics);
 
   // Email pass.
   ParseFormFieldsPass(EmailField::Parse, parse_new_field_types,
                       &remaining_fields, map);
 
   // Phone pass.
   ParseFormFieldsPass(PhoneField::Parse, parse_new_field_types,
@@ skipping 121 matching lines @@
       continue;
     }
 
     // Add entries into the map for each field type found in |form_field|.
     bool ok = form_field->ClassifyField(map);
     DCHECK(ok);
   }
 
   std::swap(*fields, remaining_fields);
 }