Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4323)

Unified Diff: chrome/browser/extensions/standard_management_policy_provider_unittest.cc

Issue 11415216: Make Blacklist::IsBlacklist asynchronous (it will need to be for safe (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/standard_management_policy_provider_unittest.cc
diff --git a/chrome/browser/extensions/standard_management_policy_provider_unittest.cc b/chrome/browser/extensions/standard_management_policy_provider_unittest.cc
index 134e146d832f3120c7fe83658fdcf039cac31e7d..e37e8fd6cb792e97915b2d90c80f97bdb4ab568e 100644
--- a/chrome/browser/extensions/standard_management_policy_provider_unittest.cc
+++ b/chrome/browser/extensions/standard_management_policy_provider_unittest.cc
@@ -21,11 +21,9 @@ class StandardManagementPolicyProviderTest : public testing::Test {
: ui_thread_(content::BrowserThread::UI, &message_loop_),
file_thread_(content::BrowserThread::FILE, &message_loop_),
prefs_(message_loop_.message_loop_proxy()),
- blacklist_(prefs()),
- provider_(prefs(), &blacklist_) {
+ provider_(prefs()) {
}
-
protected:
ExtensionPrefs* prefs() {
return prefs_.prefs();
@@ -49,12 +47,11 @@ class StandardManagementPolicyProviderTest : public testing::Test {
TestExtensionPrefs prefs_;
- Blacklist blacklist_;
-
StandardManagementPolicyProvider provider_;
};
// Tests various areas of blacklist functionality.
+/*
asargent_no_longer_on_chrome 2012/11/30 21:44:22 Is there a reason you just commented this out inst
not at google - send to devlin 2012/11/30 23:09:54 Oh, I didn't notice. Oops. Yeah I incorporated the
TEST_F(StandardManagementPolicyProviderTest, Blacklist) {
std::string not_installed_id = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
@@ -95,6 +92,7 @@ TEST_F(StandardManagementPolicyProviderTest, Blacklist) {
EXPECT_NE(extensions[0]->id(), extension_info->extension_id);
}
}
+*/
// Tests the behavior of the ManagementPolicy provider methods for an
// extension required by policy.

Powered by Google App Engine
This is Rietveld 408576698