Make Blacklist::IsBlacklist asynchronous (it will need to be for safe

chrome/browser/protector/protected_prefs_watcher_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_pref_value_map.h"
 #include "chrome/browser/extensions/extension_pref_value_map_factory.h"
 #include "chrome/browser/extensions/extension_prefs.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 114 matching lines @@
   EXPECT_FALSE(IsSignatureValid());
 
   // Flip another pref value of that extension.
   extension_prefs->SetIsIncognitoEnabled(
       sample_id, !extension_prefs->IsIncognitoEnabled(sample_id));
 
   // No changes to the backup and signature.
   EXPECT_FALSE(IsSignatureValid());
 
   // Blacklisting the extension does update the backup and signature.
-  std::set<std::string> blacklist;
-  blacklist.insert(sample_id);
-  extension_prefs->UpdateBlacklist(blacklist);
+  extension_prefs->SetExtensionBlacklisted(sample_id, true);
 
   EXPECT_TRUE(IsSignatureValid());

[not at google - send to devlin, 2012/12/03 21:27:23]

@ivankr this check is failing. Do you know what it's testing, and perhaps,
what's making it fail?

[Ivan Korotkov, 2012/12/04 12:16:20]

ProtectedPrefsWatcher maintains a copy of installed (non-blacklisted) extension
IDs and watches for its updates. Looks like some expectations it relied upon
changed. Feel free to disable the test. It's not enabled by defaylt and we're
soon going to remove this code altogether anyway.

 }
 
 // Verify that version bigger than 1 is included in the signature.
 TEST_F(ProtectedPrefsWatcherTest, VersionIsSigned) {
   // Reset version to 1.
   prefs_->ClearPref("backup._version");
   // This should make the backup invalid.
   EXPECT_FALSE(IsSignatureValid());
 
   // "Migrate" the backup back to the latest version.
@@ skipping 134 matching lines @@
             std::string(prefs::kHomePageIsNewTabPage));
   EXPECT_EQ("browser.show_home_button", std::string(prefs::kShowHomeButton));
   EXPECT_EQ("session.restore_on_startup",
             std::string(prefs::kRestoreOnStartup));
   EXPECT_EQ("session.urls_to_restore_on_startup",
             std::string(prefs::kURLsToRestoreOnStartup));
   EXPECT_EQ("pinned_tabs", std::string(prefs::kPinnedTabs));
 }
 
 }  // namespace protector