Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8154)

Unified Diff: chrome/test/chromedriver/commands_unittest.cc

Issue 11415205: [chromedriver] Implement connecting to devtools and loading a page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/commands.cc ('k') | chrome/test/chromedriver/devtools_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/commands_unittest.cc
diff --git a/chrome/test/chromedriver/commands_unittest.cc b/chrome/test/chromedriver/commands_unittest.cc
index d7612d98f037def7cdd5f92a15af3e485febcdc4..eef71364a7b0589c22dce3b7a34100d373bef8b5 100644
--- a/chrome/test/chromedriver/commands_unittest.cc
+++ b/chrome/test/chromedriver/commands_unittest.cc
@@ -27,6 +27,9 @@ class StubChrome : public Chrome {
virtual ~StubChrome() {}
// Overridden from Chrome:
+ virtual Status Load(const std::string& url) OVERRIDE {
+ return Status(kOk);
+ }
virtual Status Quit() OVERRIDE {
return Status(kOk);
}
@@ -152,7 +155,7 @@ TEST(CommandsTest, Quit) {
namespace {
-class FailsToQuitChrome : public Chrome {
+class FailsToQuitChrome : public StubChrome {
public:
FailsToQuitChrome() {}
virtual ~FailsToQuitChrome() {}
« no previous file with comments | « chrome/test/chromedriver/commands.cc ('k') | chrome/test/chromedriver/devtools_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698