Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: Source/WebCore/inspector/front-end/ConsoleMessage.js

Issue 11415185: Merge 134053 - Web Inspector: wrong output for empty object {} (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/WebCore/inspector/InjectedScriptSource.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 titleElement.createChild("span", "name").textContent = property. name; 317 titleElement.createChild("span", "name").textContent = property. name;
318 titleElement.createTextChild(": "); 318 titleElement.createTextChild(": ");
319 } 319 }
320 320
321 var span = titleElement.createChild("span", "console-formatted-" + p roperty.type); 321 var span = titleElement.createChild("span", "console-formatted-" + p roperty.type);
322 if (property.type === "object") { 322 if (property.type === "object") {
323 if (property.subtype === "node") 323 if (property.subtype === "node")
324 span.addStyleClass("console-formatted-preview-node"); 324 span.addStyleClass("console-formatted-preview-node");
325 else if (property.subtype === "regexp") 325 else if (property.subtype === "regexp")
326 span.addStyleClass("console-formatted-string"); 326 span.addStyleClass("console-formatted-string");
327 } 327 span.textContent = property.value;
328 span.textContent = property.value; 328 } else if (property.type === "function")
329 span.textContent = "function";
330 else
331 span.textContent = property.value;
329 } 332 }
330 if (preview.overflow) 333 if (preview.overflow)
331 titleElement.createChild("span").textContent = "\u2026"; 334 titleElement.createChild("span").textContent = "\u2026";
332 titleElement.createTextChild(isArray ? "]" : "}"); 335 titleElement.createTextChild(isArray ? "]" : "}");
333 return preview.lossless; 336 return preview.lossless;
334 }, 337 },
335 338
336 _formatParameterAsNode: function(object, elem) 339 _formatParameterAsNode: function(object, elem)
337 { 340 {
338 function printNode(nodeId) 341 function printNode(nodeId)
(...skipping 400 matching lines...) Expand 10 before | Expand all | Expand 10 after
739 /** 742 /**
740 * @return {WebInspector.ConsoleMessage} 743 * @return {WebInspector.ConsoleMessage}
741 */ 744 */
742 clone: function() 745 clone: function()
743 { 746 {
744 return WebInspector.ConsoleMessage.create(this.source, this.level, this. _messageText, this.type, this.url, this.line, this.repeatCount, this._parameters , this._stackTrace, this._request ? this._request.requestId : undefined, this._i sOutdated); 747 return WebInspector.ConsoleMessage.create(this.source, this.level, this. _messageText, this.type, this.url, this.line, this.repeatCount, this._parameters , this._stackTrace, this._request ? this._request.requestId : undefined, this._i sOutdated);
745 }, 748 },
746 749
747 __proto__: WebInspector.ConsoleMessage.prototype 750 __proto__: WebInspector.ConsoleMessage.prototype
748 } 751 }
OLDNEW
« no previous file with comments | « Source/WebCore/inspector/InjectedScriptSource.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698