Issue 11415083: Remove references to IDBDatabaseException and IDBRequest.errorCode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11415083: Remove references to IDBDatabaseException and IDBRequest.errorCode (Closed)

Created:
8 years, 1 month ago by jsbell

Modified:
8 years, 1 month ago

Reviewers:
dgrogan

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, alecflett

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove references to IDBDatabaseException and IDBRequest.errorCode That interface/attribute were removed from the IndexedDB spec a year ago, and are being removed from the WebKit implementation in wkbug.com/102514. Update tests to remove references, and update value checks for error codes (disabled until webkit patch lands/rolls). BUG=129766 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168904

Patch Set 1 #

Patch Set 2 : Fix error propagation from workers in endure test #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -15 lines)			Patch
M	chrome/test/data/indexeddb/endure/app.js	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/test/data/indexeddb/endure/app-worker.js	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/test/data/indexeddb/key_types_test.js	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	content/test/data/indexeddb/object_store_test.js	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/test/data/indexeddb/value_size_test.js	View		3 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/11415083/2001

8 years, 1 month ago (2012-11-20 21:14:10 UTC) #3

Change committed as 168904

Expand Messages | Collapse Messages