Add annotations on native fields and methods

sdk/lib/html/templates/html/dart2js/factoryprovider_MutationObserver.darttemplate

Index: sdk/lib/html/templates/html/dart2js/factoryprovider_MutationObserver.darttemplate
diff --git a/sdk/lib/html/templates/html/dart2js/factoryprovider_MutationObserver.darttemplate b/sdk/lib/html/templates/html/dart2js/factoryprovider_MutationObserver.darttemplate
index d92979b3943fa7acc996993f44a2d37b267efef1..affcb7c5569ac4c85ab71ca3d5b09d1506a35b32 100644
--- a/sdk/lib/html/templates/html/dart2js/factoryprovider_MutationObserver.darttemplate
+++ b/sdk/lib/html/templates/html/dart2js/factoryprovider_MutationObserver.darttemplate
@@ -5,20 +5,10 @@
 part of html;
 
 class $FACTORYPROVIDER {
-  static $CONSTRUCTOR create$(CONSTRUCTOR)(MutationCallback callback) {
 
-    // This is a hack to cause MutationRecord to appear to be instantiated.
-    //
-    // MutationCallback has a parameter type List<MutationRecord>.  From this we
-    // infer a list is created in the browser, but not the element type, because
-    // other native fields and methods return plain List which is too general
-    // and would imply creating anything.  This statement is a work-around.
-    JS('MutationRecord','0');
-
-    return _create$(CONSTRUCTOR)(callback);
-  }
-
-  static $CONSTRUCTOR _create$(CONSTRUCTOR)(MutationCallback callback) native '''
+  @Creates('MutationObserver')
+  @Creates('MutationRecord')

[vsm, 2012/11/20 18:33:46]

Should MutationRecord be somehow specified on MutationCallback instead?  E.g.,
if no passed in callback uses the MutationRecord, the type doesn't really leak
anywhere else.

[sra1, 2012/11/20 19:26:33]

1. Inference through the callback is broken for two reasons - (a) lack of stored
type parameters in the compiler causes all Lists to be inferred (b) no concrete
type implementing List<MutationRecord>.

(a) can be fixed.  (b) is how we want it - you only create instances of T from
List<T> when you access the list.  The type inference is based on concrete
types, which have precise non-parameter types on operator[].  It would be much
more complicated to implement with non-concrete types.  In the few places that
actually return JS array we have no concrete type with a specialized type on the
accessors, so we make up for that manually.

2. If you give one @Creates you must give them all - i.e. specifying
MutationObserver inhibits the use of the (overly general) types inferred from
the callback's type.

+  static $CONSTRUCTOR create$(CONSTRUCTOR)(MutationCallback callback) native '''
     var constructor =
         window.MutationObserver || window.WebKitMutationObserver ||
         window.MozMutationObserver;