Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1563)

Unified Diff: content/common/gpu/media/mac_video_decode_accelerator.mm

Issue 11415036: Forcibly disable MacVDA, even for users who ignore the GPU blacklist. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: pointing to crbug Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/functional/PYAUTO_TESTS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/media/mac_video_decode_accelerator.mm
diff --git a/content/common/gpu/media/mac_video_decode_accelerator.mm b/content/common/gpu/media/mac_video_decode_accelerator.mm
index 0f64ffb31e47d532817e04d091dc8cffbed17db9..ed8f2e6649be6c1b8a9fc5615f8ff35d844a2c3e 100644
--- a/content/common/gpu/media/mac_video_decode_accelerator.mm
+++ b/content/common/gpu/media/mac_video_decode_accelerator.mm
@@ -104,6 +104,12 @@ MacVideoDecodeAccelerator::MacVideoDecodeAccelerator(
bool MacVideoDecodeAccelerator::Initialize(media::VideoCodecProfile profile) {
DCHECK(CalledOnValidThread());
+ // MacVDA still fails on too many videos to be useful, even to users who
+ // ignore the GPU blacklist. Fail unconditionally here until enough of
+ // crbug.com/133828's blockers are resolved.
+ if (true)
+ return false;
+
if (profile < media::H264PROFILE_MIN || profile > media::H264PROFILE_MAX)
return false;
« no previous file with comments | « chrome/test/functional/PYAUTO_TESTS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698