Fix findbugs uncalled private method in WebContentsDelegateAndroid

Fix findbugs uncalled private method in WebContentsDelegateAndroid

This findbugs warning seems to be related to the overloading of the
name onLoadProgressChanged. As discussed in earlier codereview
https://codereview.chromium.org/11365199/ , it is a good idea
to have the methods differently named anyway, since they have
different purposes.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168189

[joth, 2012-11-15 18:45:15]

lgtm

Thanks!


On 15 November 2012 10:15, <jknotten@chromium.org> wrote:

> Reviewers: joth,
>
> Description:
> Fix findbugs uncalled private method in WebContentsDelegateAndroid
>
> This findbugs warning seems to be related to the overloading of the
> name onLoadProgressChanged. As discussed in earlier codereview
>
https://codereview.chromium.**org/11365199/<https://codereview.chromium.org/1...,
it is a good idea
> to have the methods differently named anyway, since they have
> different purposes.
>
> BUG=
>
>
> Please review this at
https://codereview.chromium.**org/11415011/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M build/android/findbugs_filter/**findbugs_known_bugs.txt
>   M content/components/web_**contents_delegate_android/**
> java/src/org/chromium/content/**components/web_contents_**
> delegate_android/**WebContentsDelegateAndroid.**java
>   M content/components/web_**contents_delegate_android/web_**
> contents_delegate_android.cc
>
>
> Index: build/android/findbugs_filter/**findbugs_known_bugs.txt
> diff --git a/build/android/findbugs_**filter/findbugs_known_bugs.txt
> b/build/android/findbugs_**filter/findbugs_known_bugs.txt
> index ab7a2da0a1f56afcc11ceb3ac6302d**b9f504fc31..**
> 8579fe11b113613aadfe50598232b9**0dfeee14e6 100644
> --- a/build/android/findbugs_**filter/findbugs_known_bugs.txt
> +++ b/build/android/findbugs_**filter/findbugs_known_bugs.txt
> @@ -186,7 +186,6 @@ M P SS: Unread field: org.chromium.android_webview.**
> test.util.ImagePageGenerator.
>  M P SS: Unread field: org.chromium.android_webview.**
> test.util.ImagePageGenerator.**IMAGE_SUFFIX; should this field be static?
>  At ImagePageGenerator.java
>  M P SS: Unread field: org.chromium.native_test.**
> ChromeNativeTestActivity.**EXTRA_RUN_IN_SUB_THREAD; should this field be
> static?  At ChromeNativeTestActivity.java
>  M P SS: Unread field:
org.chromium.native_test.**ChromeNativeTestActivity.TAG;
> should this field be static?  At ChromeNativeTestActivity.java
> -M P UPM: Private method org.chromium.content.**components.web_contents_**
> delegate_android.**WebContentsDelegateAndroid.**onLoadProgressChanged(double)
> is never called  At WebContentsDelegateAndroid.**java
>  M P UrF: Unread field: org.chromium.content.browser.**
> ContentViewGestureHandlerTest$**MockListener.mLastFling2  At
> ContentViewGestureHandlerTest.**java
>  M P UrF: Unread field: org.chromium.content.browser.**
> ContentViewGestureHandlerTest$**MockListener.mLastScroll1  At
> ContentViewGestureHandlerTest.**java
>  M P UrF: Unread field: org.chromium.content.browser.**
> ContentViewGestureHandlerTest$**MockListener.mLastScroll2  At
> ContentViewGestureHandlerTest.**java
> Index: content/components/web_**contents_delegate_android/**
> java/src/org/chromium/content/**components/web_contents_**
> delegate_android/**WebContentsDelegateAndroid.**java
> diff --git a/content/components/web_**contents_delegate_android/**
> java/src/org/chromium/content/**components/web_contents_**
> delegate_android/**WebContentsDelegateAndroid.**java
> b/content/components/web_**contents_delegate_android/**
> java/src/org/chromium/content/**components/web_contents_**
> delegate_android/**WebContentsDelegateAndroid.**java
> index 1fc468724fb4e77dd7718891ac87da**29fa42f16c..**
> a4614cb40f64f4e3ebcbb4d973f4f8**c69d62e3e5 100644
> --- a/content/components/web_**contents_delegate_android/**
> java/src/org/chromium/content/**components/web_contents_**
> delegate_android/**WebContentsDelegateAndroid.**java
> +++ b/content/components/web_**contents_delegate_android/**
> java/src/org/chromium/content/**components/web_contents_**
> delegate_android/**WebContentsDelegateAndroid.**java
> @@ -65,7 +65,7 @@ public class WebContentsDelegateAndroid {
>
>      @SuppressWarnings("unused")
>      @CalledByNative
> -    private final void onLoadProgressChanged(double progress) {
> +    private final void notifyLoadProgressChanged(**double progress) {
>          mMostRecentProgress = (int) (100.0 * progress);
>          onLoadProgressChanged(**mMostRecentProgress);
>      }
> Index: content/components/web_**contents_delegate_android/web_**
> contents_delegate_android.cc
> diff --git
a/content/components/web_**contents_delegate_android/web_**contents_delegate_android.cc
> b/content/components/web_**contents_delegate_android/web_**
> contents_delegate_android.cc
> index 9256aa3359e077674eb23dbb3e0990**a82e0fef6c..**
> e212b2c7bbcabc9e091d589a64b903**ffe192593e 100644
> --- a/content/components/web_**contents_delegate_android/web_**
> contents_delegate_android.cc
> +++ b/content/components/web_**contents_delegate_android/web_**
> contents_delegate_android.cc
> @@ -151,7 +151,7 @@ void WebContentsDelegateAndroid::**
> LoadProgressChanged(**WebContents* source,
>    ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env);
>    if (obj.is_null())
>      return;
> -  Java_**WebContentsDelegateAndroid_**onLoadProgressChanged(
> +  Java_**WebContentsDelegateAndroid_**notifyLoadProgressChanged(
>        env,
>        obj.obj(),
>        progress);
>
>
>

[commit-bot: I haz the power, 2012-11-15 21:42:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jknotten@chromium.org/11415011/1

[commit-bot: I haz the power, 2012-11-15 21:47:10]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-16 11:12:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jknotten@chromium.org/11415011/1

[commit-bot: I haz the power, 2012-11-16 11:54:41]

Change committed as 168189