Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9319)

Unified Diff: chrome/browser/autocomplete/autocomplete_controller.h

Issue 11414303: Make Google Search autocomplete provider cursor aware. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_controller.h
diff --git a/chrome/browser/autocomplete/autocomplete_controller.h b/chrome/browser/autocomplete/autocomplete_controller.h
index 2339c70965dc71b71e450200b716ca0f08e2126f..0327e34c731d1f67288f892af3e8eb2ce166da65 100644
--- a/chrome/browser/autocomplete/autocomplete_controller.h
+++ b/chrome/browser/autocomplete/autocomplete_controller.h
@@ -59,38 +59,15 @@ class AutocompleteController : public AutocompleteProviderListener {
// done or the query is Stop()ed. It is safe to Start() a new query without
// Stop()ing the previous one.
//
- // See AutocompleteInput::desired_tld() for meaning of |desired_tld|.
- //
- // |prevent_inline_autocomplete| is true if the generated result set should
- // not require inline autocomplete for the default match. This is difficult
- // to explain in the abstract; the practical use case is that after the user
- // deletes text in the edit, the HistoryURLProvider should make sure not to
- // promote a match requiring inline autocomplete too highly.
- //
- // |prefer_keyword| should be true when the keyword UI is onscreen; this will
- // bias the autocomplete result set toward the keyword provider when the input
- // string is a bare keyword.
- //
- // |allow_exact_keyword_match| should be false when triggering keyword mode on
- // the input string would be surprising or wrong, e.g. when highlighting text
- // in a page and telling the browser to search for it or navigate to it. This
- // parameter only applies to substituting keywords.
-
- // If |matches_requested| is BEST_MATCH or SYNCHRONOUS_MATCHES the controller
- // asks the providers to only return matches which are synchronously
- // available, which should mean that all providers will be done immediately.
+ // See AutocompleteInput::AutocompleteInput(...) for more details regarding
+ // |input| params.
//
// The controller calls AutocompleteControllerDelegate::OnResultChanged() from
// inside this call at least once. If matches are available later on that
// result in changing the result set the delegate is notified again. When the
// controller is done the notification AUTOCOMPLETE_CONTROLLER_RESULT_READY is
// sent.
- void Start(const string16& text,
- const string16& desired_tld,
- bool prevent_inline_autocomplete,
- bool prefer_keyword,
- bool allow_exact_keyword_match,
- AutocompleteInput::MatchesRequested matches_requested);
+ void Start(const AutocompleteInput& input);
// Cancels the current query, ensuring there will be no future notifications
// fired. If new matches have come in since the most recent notification was

Powered by Google App Engine
This is Rietveld 408576698