Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11414294: Add a "managed user settings" page to chrome://settings. (Closed)

Created:
8 years ago by Bernhard Bauer
Modified:
8 years ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, finnur+watch_chromium.org, arv (Not doing code reviews), jshin+watch_chromium.org
Visibility:
Public.

Description

Add a "managed user settings" page to chrome://settings. It's only accessible at chrome://settings/managedUser and requires the --enable-managed-users switch. Also, not all of the settings are hooked up yet. TBR=ben@chromium.org,cpu@chromium.org BUG=163884 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171065

Patch Set 1 #

Patch Set 2 : . #

Total comments: 6

Patch Set 3 : review #

Total comments: 2

Patch Set 4 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -11 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings.grd View 1 chunk +5 lines, -0 lines 0 comments Download
A + chrome/browser/resources/options/managed_user_settings.css View 1 2 1 chunk +6 lines, -11 lines 0 comments Download
A chrome/browser/resources/options/managed_user_settings.html View 1 1 chunk +86 lines, -0 lines 0 comments Download
A chrome/browser/resources/options/managed_user_settings.js View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options.html View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options.js View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options_bundle.js View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/ui/webui/options/managed_user_settings_handler.h View 1 chunk +27 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/options/managed_user_settings_handler.cc View 1 2 3 1 chunk +55 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Bernhard Bauer
Please review.
8 years ago (2012-12-03 18:07:55 UTC) #1
Evan Stade
would prefer it to be behind a flag as you develop. Otherwise lgtm. https://codereview.chromium.org/11414294/diff/2001/chrome/browser/resources/options/managed_user_settings.css File ...
8 years ago (2012-12-03 20:03:25 UTC) #2
Bernhard Bauer
TBR'ing other OWNERS: Ben -- File additions Carlos -- chrome/app/resourcces/locale_settings.grd On 2012/12/03 20:03:25, Evan Stade ...
8 years ago (2012-12-03 20:34:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/11414294/5014
8 years ago (2012-12-03 20:35:02 UTC) #4
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/11414294/diff/5014/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/11414294/diff/5014/chrome/app/generated_resources.grd#newcode8047 chrome/app/generated_resources.grd:8047: + <message name="IDS_MANAGED_USER_SETTINGS_PAGE_TITLE" desc="Dialog title"> is it a page ...
8 years ago (2012-12-03 21:00:27 UTC) #5
Bernhard Bauer
https://codereview.chromium.org/11414294/diff/5014/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/11414294/diff/5014/chrome/app/generated_resources.grd#newcode8047 chrome/app/generated_resources.grd:8047: + <message name="IDS_MANAGED_USER_SETTINGS_PAGE_TITLE" desc="Dialog title"> On 2012/12/03 21:00:28, cpu ...
8 years ago (2012-12-03 21:12:08 UTC) #6
Ben Goodger (Google)
gyp lgtm
8 years ago (2012-12-04 16:21:33 UTC) #7
cpu_(ooo_6.6-7.5)
lgtm
8 years ago (2012-12-04 19:10:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/11414294/11002
8 years ago (2012-12-04 19:21:29 UTC) #9
commit-bot: I haz the power
8 years ago (2012-12-04 22:38:25 UTC) #10
Message was sent while issue was closed. 
Change committed as 171065

Powered by Google App Engine
This is Rietveld 408576698