Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11414286: Remove unneeded TabContents::FromWebContents. (Closed)

Created:
8 years ago by Avi (use Gerrit)
Modified:
8 years ago
CC:
chromium-reviews, groby+watch_chromium.org, akalin, Raghu Simha, kkania, marja+watch_chromium.org, scheib+watch_chromium.org, robertshield, tfarina, gbillock+watch_chromium.org, smckay+watch_chromium.org, haitaol1, rouslan+watch_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Remove unneeded TabContents::FromWebContents. BUG=107201 TEST=no visible change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170902

Patch Set 1 #

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -167 lines) Patch
M chrome/browser/automation/automation_provider_observers.h View 7 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/intents/register_intent_handler_helper.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service_helper.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/auto_login_info_bar_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller.h View 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller.cc View 14 chunks +25 lines, -38 lines 0 comments Download
M chrome/browser/ui/gtk/web_intent_picker_gtk.h View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/web_intent_picker_gtk.cc View 1 15 chunks +24 lines, -25 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_unsupported_feature.cc View 12 chunks +26 lines, -27 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/web_intent_picker_views.cc View 1 7 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
8 years ago (2012-12-01 23:31:43 UTC) #1
Ben Goodger (Google)
lgtm
8 years ago (2012-12-02 01:26:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11414286/6001
8 years ago (2012-12-03 21:22:09 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-04 02:06:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11414286/6001
8 years ago (2012-12-04 03:35:15 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-04 07:39:55 UTC) #6
Message was sent while issue was closed. 
Change committed as 170902

Powered by Google App Engine
This is Rietveld 408576698