Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 11414276: Polish UX of chrome://settings/display (Closed)

Created:
8 years ago by Jun Mukai
Modified:
8 years ago
Reviewers:
xiyuan, oshima
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv (Not doing code reviews), stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Polish UX of chrome://settings/display Following minor fixes are included: - handling mouse up event outside of the area - the display text is not selectable by -webkit-user-select - hide 'Make primary' button rather than disabling it - fix the position of white pointing arrow - changes the space between "mirroring" and "make primary" button - fix the position of display name text so that it won't change when the display gets the focus - remove 'dirty' flag. rather checks if the drop position is exactly same as the original position or not. - changes the background mirroring display rectangle from dash to solid, also changes the margin between displays in mirroring to 2. BUG=163546 TEST=make sure by operating in chrome://settings/display on an actual device. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170650

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -25 lines) Patch
M chrome/browser/resources/options/chromeos/display_options.css View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/chromeos/display_options.js View 11 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jun Mukai
8 years ago (2012-11-30 23:14:11 UTC) #1
xiyuan
lgtm https://codereview.chromium.org/11414276/diff/1/chrome/browser/resources/options/chromeos/display_options.css File chrome/browser/resources/options/chromeos/display_options.css (right): https://codereview.chromium.org/11414276/diff/1/chrome/browser/resources/options/chromeos/display_options.css#newcode99 chrome/browser/resources/options/chromeos/display_options.css:99: padding: 5px 0 5px 0; nit: padding: 5px ...
8 years ago (2012-11-30 23:19:59 UTC) #2
Jun Mukai
https://codereview.chromium.org/11414276/diff/1/chrome/browser/resources/options/chromeos/display_options.css File chrome/browser/resources/options/chromeos/display_options.css (right): https://codereview.chromium.org/11414276/diff/1/chrome/browser/resources/options/chromeos/display_options.css#newcode99 chrome/browser/resources/options/chromeos/display_options.css:99: padding: 5px 0 5px 0; On 2012/11/30 23:19:59, xiyuan ...
8 years ago (2012-11-30 23:22:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/11414276/4001
8 years ago (2012-11-30 23:23:07 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years ago (2012-11-30 23:28:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/11414276/4001
8 years ago (2012-11-30 23:34:18 UTC) #6
commit-bot: I haz the power
8 years ago (2012-12-01 03:39:21 UTC) #7
Message was sent while issue was closed.
Change committed as 170650

Powered by Google App Engine
This is Rietveld 408576698