Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: chrome/browser/ui/views/autofill/autofill_external_delegate_views_browsertest.cc

Issue 11414266: Hide new Autofill Popup on Main Widget Resize or Move. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/autofill/autofill_external_delegate_views_browsertest.cc
diff --git a/chrome/browser/ui/views/autofill/autofill_external_delegate_views_browsertest.cc b/chrome/browser/ui/views/autofill/autofill_external_delegate_views_browsertest.cc
index 60a3c226bc5f55d52a48c01a57dbb53337bf854f..083734941e4c9f1947bb4cfb845485b85ae2843b 100644
--- a/chrome/browser/ui/views/autofill/autofill_external_delegate_views_browsertest.cc
+++ b/chrome/browser/ui/views/autofill/autofill_external_delegate_views_browsertest.cc
@@ -71,18 +71,20 @@ IN_PROC_BROWSER_TEST_F(AutofillExternalDelegateViewsBrowserTest,
EXPECT_TRUE(autofill_external_delegate_->popup_hidden_);
}
+// See http://crbug.com/164019
+#if !defined(USE_AURA)
IN_PROC_BROWSER_TEST_F(AutofillExternalDelegateViewsBrowserTest,
CloseWidgetAndNoLeaking) {
autofill::GenerateTestAutofillPopup(autofill_external_delegate_.get());
-
// Delete the widget to ensure that the external delegate can handle the
- // popup getting deleted elsewhere and the .
+ // popup getting deleted elsewhere.
views::Widget* popup_widget =
autofill_external_delegate_->popup_view()->GetWidget();
popup_widget->CloseNow();
EXPECT_TRUE(autofill_external_delegate_->popup_hidden_);
}
+#endif // !defined(USE_AURA)
IN_PROC_BROWSER_TEST_F(AutofillExternalDelegateViewsBrowserTest,
HandlePopupClosingAndChangingPages) {
« no previous file with comments | « ash/system/tray/tray_background_view.cc ('k') | chrome/browser/ui/views/autofill/autofill_popup_view_views.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698