Issue 11414266: Hide new Autofill Popup on Main Widget Resize or Move.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11414266: Hide new Autofill Popup on Main Widget Resize or Move. (Closed)

Created:
8 years ago by csharp

Modified:
8 years ago

Reviewers:

CC:
chromium-reviews, tfarina, dhollowa+watch_chromium.org, dbeam+watch-autofill_chromium.org, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Hide new Autofill Popup on Main Widget Resize or Move. This will hide the popup when the browser changes size or location. Also add some tests for the WidgetObserver for the function we are observing with. Resubmitting https://codereview.chromium.org/11308124/ with CloseWidgetAndNoLeaking disable on aura TBR=sky@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170864

Patch Set 1 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -15 lines)			Patch
M	ash/system/tray/tray_background_view.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/autofill/autofill_external_delegate_views_browsertest.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/autofill/autofill_popup_view_views.h	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/autofill/autofill_popup_view_views.cc	View	4 chunks	+19 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_drag_controller.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_drag_controller.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/views/bubble/bubble_delegate.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	ui/views/bubble/bubble_delegate.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	ui/views/widget/widget.cc	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	ui/views/widget/widget_observer.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	ui/views/widget/widget_unittest.cc	View	6 chunks	+27 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/11414266/7017

8 years ago (2012-12-03 22:12:14 UTC) #1

Message was sent while issue was closed.

Change committed as 170864

Expand Messages | Collapse Messages