Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 11414265: gfx: Inline the constructors and destructors for RectBase. (Closed)

Created:
8 years ago by danakj
Modified:
8 years ago
Reviewers:
jamesr, sky
CC:
chromium-reviews, cc-bugs_chromium.org, piman, backer
Visibility:
Public.

Description

gfx: Inline the constructors and destructors for RectBase. This gives a 5% increase in cc_perftests. Before: *RESULT SevenTabSwitcher: frames= 1519.00 runs/s *RESULT 10_10_layer_tree: frames= 541.09 runs/s After: *RESULT SevenTabSwitcher: frames= 1594.62 runs/s *RESULT 10_10_layer_tree: frames= 569.31 runs/s BUG=163035 R=jamesr,sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -46 lines) Patch
M ui/gfx/rect_base.h View 1 chunk +7 lines, -4 lines 0 comments Download
M ui/gfx/rect_base_impl.h View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danakj
8 years ago (2012-11-30 18:45:54 UTC) #1
jamesr
nice! lgtm
8 years ago (2012-11-30 19:22:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11414265/1
8 years ago (2012-11-30 19:23:35 UTC) #3
commit-bot: I haz the power
8 years ago (2012-11-30 21:49:43 UTC) #4
Message was sent while issue was closed.
Change committed as 170559

Powered by Google App Engine
This is Rietveld 408576698