Simplify local path resolution in fileBrowserPrivate API implementation (part 1).

chrome/browser/chromeos/extensions/file_browser_private_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_BROWSER_PRIVATE_API_H_
 #define CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_BROWSER_PRIVATE_API_H_
 
 #include <map>
 #include <queue>
 #include <string>
@@ skipping 58 matching lines @@
       scoped_refptr<FileBrowserEventRouter> event_router,
       const FilePath& local_path, const FilePath& virtual_path,
       const std::string& extension_id) = 0;
 
   // AsyncExtensionFunction overrides.
   virtual bool RunImpl() OVERRIDE;
 
  private:
   void RespondOnUIThread(bool success);
   void RunFileWatchOperationOnFileThread(
-      scoped_refptr<fileapi::FileSystemContext> file_system_context,
       scoped_refptr<FileBrowserEventRouter> event_router,
       const GURL& file_url,
       const std::string& extension_id);
 };
 
 // Implements the chrome.fileBrowserPrivate.addFileWatch method.
 class AddFileWatchBrowserFunction : public FileWatchBrowserFunctionBase {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("fileBrowserPrivate.addFileWatch");
 
@@ skipping 177 matching lines @@
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("fileBrowserPrivate.viewFiles");
 
   ViewFilesFunction();
 
  protected:
   virtual ~ViewFilesFunction();
 
   // AsyncExtensionFunction overrides.
   virtual bool RunImpl() OVERRIDE;
-
- private:
-  // A callback method to handle the result of
-  // GetLocalPathsOnFileThreadAndRunCallbackOnUIThread.
-  void GetLocalPathsResponseOnUIThread(const std::string& internal_task_id,
-                                       const SelectedFileInfoList& files);
 };
 
 // Select multiple files.  Closes the dialog window.
 class SelectFilesFunction : public FileBrowserFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("fileBrowserPrivate.selectFiles");
 
   SelectFilesFunction();
 
  protected:
@@ skipping 84 matching lines @@
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("fileBrowserPrivate.formatDevice");
 
   FormatDeviceFunction();
 
  protected:
   virtual ~FormatDeviceFunction();
 
   // AsyncExtensionFunction overrides.
   virtual bool RunImpl() OVERRIDE;
-
- private:
-  // A callback method to handle the result of
-  // GetLocalPathsOnFileThreadAndRunCallbackOnUIThread.
-  void GetLocalPathsResponseOnUIThread(const SelectedFileInfoList& files);
 };
 
 // Sets last modified date in seconds of local file
 class SetLastModifiedFunction : public FileBrowserFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("fileBrowserPrivate.setLastModified");
 
   SetLastModifiedFunction();
 
  protected:
@@ skipping 11 matching lines @@
 
   GetSizeStatsFunction();
 
  protected:
   virtual ~GetSizeStatsFunction();
 
   // AsyncExtensionFunction overrides.
   virtual bool RunImpl() OVERRIDE;
 
  private:
-  // A callback method to handle the result of
-  // GetLocalPathsOnFileThreadAndRunCallbackOnUIThread.
-  void GetLocalPathsResponseOnUIThread(const SelectedFileInfoList& files);
-
   void GetDriveAvailableSpaceCallback(drive::DriveFileError error,
                                       int64 bytes_total,
                                       int64 bytes_used);
 
   void GetSizeStatsCallbackOnUIThread(size_t total_size_kb,
                                       size_t remaining_size_kb);
   void CallGetSizeStatsOnFileThread(const std::string& mount_path);
 };
 
 // Retrieves devices meta-data. Expects volume's device path as an argument.
 class GetVolumeMetadataFunction : public FileBrowserFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("fileBrowserPrivate.getVolumeMetadata");
 
   GetVolumeMetadataFunction();
 
  protected:
   virtual ~GetVolumeMetadataFunction();
 
   // AsyncExtensionFunction overrides.
   virtual bool RunImpl() OVERRIDE;
-
- private:
-  // A callback method to handle the result of
-  // GetLocalPathsOnFileThreadAndRunCallbackOnUIThread.
-  void GetLocalPathsResponseOnUIThread(const SelectedFileInfoList& files);
 };
 
 // Toggles fullscreen mode for the browser.
 class ToggleFullscreenFunction : public SyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("fileBrowserPrivate.toggleFullscreen");
 
  protected:
   virtual ~ToggleFullscreenFunction() {}
 
@@ skipping 104 matching lines @@
   void OnPinStateSet(const FilePath& path,
                      base::DictionaryValue* properties,
                      scoped_ptr<drive::DriveEntryProto> entry_proto,
                      drive::DriveFileError error);
 
   // True for pin, false for unpin.
   bool set_pin_;
 };
 
 // Get file locations for the given list of file URLs. Returns a list of
-// location idenfitiers, like ['drive', 'local'], where 'drive' means the
+// location identifiers, like ['drive', 'local'], where 'drive' means the
 // file is on gdata, and 'local' means the file is on the local drive.
 class GetFileLocationsFunction : public FileBrowserFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("fileBrowserPrivate.getFileLocations");
 
   GetFileLocationsFunction();
 
  protected:
   virtual ~GetFileLocationsFunction();
 
   // AsyncExtensionFunction overrides.
   virtual bool RunImpl() OVERRIDE;
-
- private:
-  // A callback method to handle the result of
-  // GetLocalPathsOnFileThreadAndRunCallbackOnUIThread.
-  void GetLocalPathsResponseOnUIThread(const SelectedFileInfoList& files);
 };
 
 // Get gdata files for the given list of file URLs. Initiate downloading of
 // gdata files if these are not cached. Return a list of local file names.
 // This function puts empty strings instead of local paths for files could
 // not be obtained. For instance, this can happen if the user specifies a new
 // file name to save a file on gdata. There may be other reasons to fail. The
 // file manager should check if the local paths returned from getDriveFiles()
 // contain empty paths.
 // TODO(satorux): Should we propagate error types to the JavasScript layer?
@@ skipping 51 matching lines @@
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("fileBrowserPrivate.cancelFileTransfers");
 
   CancelFileTransfersFunction();
 
  protected:
   virtual ~CancelFileTransfersFunction();
 
   // AsyncExtensionFunction overrides.
   virtual bool RunImpl() OVERRIDE;
-
-  void GetLocalPathsResponseOnUIThread(const SelectedFileInfoList& files);
 };
 
 // Implements the chrome.fileBrowserPrivate.transferFile method.
 class TransferFileFunction : public FileBrowserFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("fileBrowserPrivate.transferFile");
 
   TransferFileFunction();
 
  protected:
   virtual ~TransferFileFunction();
 
   // AsyncExtensionFunction overrides.
   virtual bool RunImpl() OVERRIDE;
 
  private:
-  // Helper callback for handling response from
-  // GetLocalPathsOnFileThreadAndRunCallbackOnUIThread()
-  void GetLocalPathsResponseOnUIThread(const SelectedFileInfoList& files);
-
   // Helper callback for handling response from DriveFileSystem::TransferFile().
   void OnTransferCompleted(drive::DriveFileError error);
 };
 
 // Read setting value.
 class GetPreferencesFunction : public SyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("fileBrowserPrivate.getPreferences");
 
  protected:
@@ skipping 100 matching lines @@
  protected:
   virtual ~ZipSelectionFunction();
 
   // AsyncExtensionFunction overrides.
   virtual bool RunImpl() OVERRIDE;
 
   // extensions::ZipFileCreator::Delegate overrides.
   virtual void OnZipDone(bool success) OVERRIDE;
 
  private:
-  // A callback method to handle the result of
-  // GetLocalPathsOnFileThreadAndRunCallbackOnUIThread.
-  void GetLocalPathsResponseOnUIThread(const std::string dest_name,
-                                       const SelectedFileInfoList& files);
-
   scoped_refptr<extensions::ZipFileCreator> zip_file_creator_;
 };
 
 #endif  // CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_BROWSER_PRIVATE_API_H_