Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 11414221: Media Galleries: On Linux, write data to snapshots in chunks rather than at once. (Closed)

Created:
8 years ago by Lei Zhang
Modified:
8 years ago
Reviewers:
kmadhusu
CC:
chromium-reviews
Visibility:
Public.

Description

Media Galleries: On Linux, write data to snapshots in chunks rather than at once. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170414

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Total comments: 10

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -34 lines) Patch
M chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc View 1 2 3 6 chunks +57 lines, -34 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
8 years ago (2012-11-29 02:47:42 UTC) #1
kmadhusu
https://codereview.chromium.org/11414221/diff/1/chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc File chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc (left): https://codereview.chromium.org/11414221/diff/1/chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc#oldcode385 chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc:385: if (on_shutdown_event_->IsSignaled()) Instead of moving this logic from ReadFileWorker ...
8 years ago (2012-11-29 18:08:17 UTC) #2
Lei Zhang
https://codereview.chromium.org/11414221/diff/1/chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc File chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc (left): https://codereview.chromium.org/11414221/diff/1/chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc#oldcode385 chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc:385: if (on_shutdown_event_->IsSignaled()) On 2012/11/29 18:08:17, kmadhusu wrote: > Instead ...
8 years ago (2012-11-30 01:01:34 UTC) #3
kmadhusu
https://codereview.chromium.org/11414221/diff/5001/chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc File chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc (right): https://codereview.chromium.org/11414221/diff/5001/chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc#newcode448 chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc:448: file_util::WriteFileDescriptor(dest_fd_, data.data(), data.size()); You are trying to do a ...
8 years ago (2012-11-30 01:13:09 UTC) #4
Lei Zhang
See patch set 3.
8 years ago (2012-11-30 01:47:28 UTC) #5
kmadhusu
https://codereview.chromium.org/11414221/diff/7001/chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc File chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc (right): https://codereview.chromium.org/11414221/diff/7001/chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc#newcode400 chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc:400: } When the MTR resumes, if |error_occured_| is true, ...
8 years ago (2012-11-30 02:05:12 UTC) #6
Lei Zhang
https://codereview.chromium.org/11414221/diff/7001/chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc File chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc (right): https://codereview.chromium.org/11414221/diff/7001/chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc#newcode400 chrome/browser/media_gallery/mtp_device_delegate_impl_linux.cc:400: } On 2012/11/30 02:05:12, kmadhusu wrote: > When the ...
8 years ago (2012-11-30 02:30:55 UTC) #7
kmadhusu
lgtm
8 years ago (2012-11-30 02:39:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/11414221/7002
8 years ago (2012-11-30 03:59:35 UTC) #9
commit-bot: I haz the power
8 years ago (2012-11-30 07:27:38 UTC) #10
Message was sent while issue was closed.
Change committed as 170414

Powered by Google App Engine
This is Rietveld 408576698