Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tools/code_coverage/coverage_posix.py

Issue 11414214: Enable only 'downloads' related tests in browser_tests on coverage bot. (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/code_coverage/coverage_posix.py
===================================================================
--- tools/code_coverage/coverage_posix.py (revision 169901)
+++ tools/code_coverage/coverage_posix.py (working copy)
@@ -244,7 +244,27 @@
'AutomatedUITestBase.DragOut',), },
}
+"""Since random tests are failing/hanging on coverage bot, we are enabling
+ tests feature by feature. crbug.com/159748
+ Below are the downloads related tests enabled.
+ SavePageBrowserTest.*
+ SavePageAsMHTMLBrowserTest.*
+ DownloadQueryTest.*
+ DownloadDangerPromptTest.*
+ DownloadTest.*
+"""
+gTestInclusions = {
+ 'linux2': {
+ 'browser_tests':
+ ('SavePageBrowserTest.*',
+ 'SavePageAsMHTMLBrowserTest.*',
+ 'DownloadQueryTest.*',
+ 'DownloadDangerPromptTest.*',
+ 'DownloadTest.*',),
+ },
+}
+
def TerminateSignalHandler(sig, stack):
"""When killed, try and kill our child processes."""
signal.signal(sig, signal.SIG_DFL)
@@ -783,6 +803,13 @@
if test in fulltest:
negative_gfilter_list += excldict[test]
+ inclusions = gTestInclusions
+ include_dict = inclusions.get(sys.platform)
+ if include_dict:
+ for test in include_dict.keys():
+ if test in fulltest:
+ positive_gfilter_list += include_dict[test]
+
fulltest_basename = os.path.basename(fulltest)
if fulltest_basename in self.test_filters:
specific_test_filters = self.test_filters[fulltest_basename].split('-')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698