Issue 11414208: Don't delay tap down(show_press) gesture events on gesture_event_filter for Android

Issue 11414208: Don't delay tap down(show_press) gesture events on gesture_event_filter for Android (Closed)

Created:
8 years ago by Yusuf

Modified:
8 years ago

Reviewers:
rjkroege, aelias_OOO_until_Jul13, Yaron

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, rjkroege, klobag.chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't delay tap down(show_press) gesture events on gesture_event_filter This gesture comes from the Android framework with a 150 ms delay already. We don't need the deferral on gesture_event_filter. BUG=162767 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170401

Patch Set 1 #

Patch Set 2 : Added the change to gesture_event_filter instead of content_switches #

Total comments: 1

Patch Set 3 : Added comments #

Patch Set 4 : Fixed unittests #

Patch Set 5 : Rebased #

Patch Set 6 : fixed build errors #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	content/browser/renderer_host/gesture_event_filter.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	content/browser/renderer_host/render_widget_host_unittest.cc	View	1 2 3 4 5	2 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

Yusuf

After talking with rjkroege@ about this, it seems changing the default value in gesture_event_filter for ...

8 years ago (2012-11-28 22:23:58 UTC) #4

aelias_OOO_until_Jul13

lgtm https://codereview.chromium.org/11414208/diff/4001/content/browser/renderer_host/gesture_event_filter.cc File content/browser/renderer_host/gesture_event_filter.cc (right): https://codereview.chromium.org/11414208/diff/4001/content/browser/renderer_host/gesture_event_filter.cc#newcode24 content/browser/renderer_host/gesture_event_filter.cc:24: static const int kTapDownDeferralTimeMs = 0; Please add ...

8 years ago (2012-11-28 22:32:35 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/11414208/6003

8 years ago (2012-11-29 16:38:02 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/11414208/9003

8 years ago (2012-11-29 22:36:50 UTC) #8

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

8 years ago (2012-11-29 22:59:06 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/11414208/12003

8 years ago (2012-11-29 23:46:54 UTC) #10

Message was sent while issue was closed.

Change committed as 170401

Expand Messages | Collapse Messages