Delay scroll to section until page initialization is complete.

Delay scroll to section until page initialization is complete.

BUG=153777
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170572

[kevers, 2012-11-28 14:05:40]

Hi James,

Can you please have a look at this CL.  Synchronizes scrolling to a section
after page navigation.  On navigating to a dialog that is associated with a
section, a check is made to see if advanced settings need to be opened and if
the associated section is visible on screen, scrolling if required.  The problem
was that the scroll was occurring before page initialization was complete in
some cases, resulting in an incorrect scroll offset.  For example, the Bluetooth
section is closed initially, and its state is corrected in the InitializePage
method of the UI handler.  With the fix, scrolling is deferred until page
loading completes.

[James Hawkins, 2012-11-29 23:20:21]

https://codereview.chromium.org/11414204/diff/2001/chrome/browser/resources/o...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/11414204/diff/2001/chrome/browser/resources/o...
chrome/browser/resources/options/browser_options.js:49:
this.initializationComplete_ = false;
Why do we need to set this here?  Does reinitialization happen?

[kevers, 2012-11-30 19:46:25]

https://codereview.chromium.org/11414204/diff/2001/chrome/browser/resources/o...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/11414204/diff/2001/chrome/browser/resources/o...
chrome/browser/resources/options/browser_options.js:49:
this.initializationComplete_ = false;
On 2012/11/29 23:20:21, James Hawkins wrote:
> Why do we need to set this here?  Does reinitialization happen?

Flag reset is redundant.  Removed.

[James Hawkins, 2012-11-30 19:51:07]

LGTM but I'd like to note that this doesn't scale, i.e., I don't think this will
handle other methods that need to wait for initialization.

[commit-bot: I haz the power, 2012-11-30 20:23:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/11414204/7001

[commit-bot: I haz the power, 2012-11-30 22:19:13]

Change committed as 170572