Issue 11414155: Ensure double arrays are filled with holes when extended from variations of empty arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11414155: Ensure double arrays are filled with holes when extended from variations of empty arrays. (Closed)

Created:
8 years ago by Toon Verwaest

Modified:
8 years ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Ensure double arrays are filled with holes when extended from variations of empty arrays. BUG=162085 Committed: https://code.google.com/p/v8/source/detail?r=13056

Patch Set 1 : u #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -70 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	3 chunks	+20 lines, -3 lines	0 comments	Download
M	src/elements.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	2 chunks	+12 lines, -3 lines	0 comments	Download
M	src/parser.cc	View	3 chunks	+0 lines, -9 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	5 chunks	+15 lines, -4 lines	0 comments	Download
M	test/mjsunit/array-natives-elements.js	View	6 chunks	+6 lines, -6 lines	0 comments	Download
A +	test/mjsunit/regress/regress-crbug-162085.js	View	1 chunk	+24 lines, -41 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adamk

8 years ago (2012-11-28 22:52:53 UTC) #3

Message was sent while issue was closed.

Based on some work running git bisect, this caused a regression I've reported as
https://code.google.com/p/v8/issues/detail?id=2433. Please take a look.

Expand Messages | Collapse Messages