Issue 11414153: Remove legacy constrained window dialogs

Issue 11414153: Remove legacy constrained window dialogs (Closed)

Created:
8 years ago by sail

Modified:
8 years ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, gbillock+watch_chromium.org, smckay+watch_chromium.org, groby+watch_chromium.org, rouslan+watch_chromium.org, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove legacy constrained window dialogs This CL removes the following legacy constrained window dialogs: - TabModalConfirmDialogMac, replaced by TabModalConfirmDialogMac2 - WebIntentPickerCocoa, replaced by WebIntentPickerCocoa2 BUG= TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169607

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -2390 lines)			Patch
M	chrome/browser/ui/cocoa/intents/web_intent_inline_service_view_controller.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/intents/web_intent_inline_service_view_controller.mm	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/intents/web_intent_inline_service_view_controller_browsertest.mm	View	3 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/ui/cocoa/intents/web_intent_picker_cocoa.h	View	3 chunks	+12 lines, -13 lines	0 comments	Download
A +	chrome/browser/ui/cocoa/intents/web_intent_picker_cocoa.mm	View	5 chunks	+31 lines, -24 lines	0 comments	Download
D	chrome/browser/ui/cocoa/intents/web_intent_picker_cocoa2.h	View	1 chunk	+0 lines, -87 lines	0 comments	Download
D	chrome/browser/ui/cocoa/intents/web_intent_picker_cocoa2.mm	View	1 chunk	+0 lines, -146 lines	0 comments	Download
M	chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.mm	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller_browsertest.mm	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.h	View	3 chunks	+7 lines, -32 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm	View	4 chunks	+6 lines, -94 lines	0 comments	Download
D	chrome/browser/ui/cocoa/web_intent_picker_cocoa.h	View	1 chunk	+0 lines, -103 lines	0 comments	Download
D	chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm	View	1 chunk	+0 lines, -256 lines	0 comments	Download
D	chrome/browser/ui/cocoa/web_intent_sheet_controller.h	View	1 chunk	+0 lines, -77 lines	0 comments	Download
D	chrome/browser/ui/cocoa/web_intent_sheet_controller.mm	View	1 chunk	+0 lines, -1192 lines	0 comments	Download
D	chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm	View	1 chunk	+0 lines, -85 lines	0 comments	Download
D	chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm	View	1 chunk	+0 lines, -257 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/11414153/1

8 years ago (2012-11-27 05:19:14 UTC) #3

commit-bot: I haz the power

Presubmit check for 11414153-1 failed and returned exit status 1. Running presubmit commit checks ...

8 years ago (2012-11-27 05:19:20 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/11414153/1

8 years ago (2012-11-27 05:21:58 UTC) #5

Message was sent while issue was closed.

Change committed as 169607

Expand Messages | Collapse Messages