Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11414152: Drive: Rename GData to Drive in extension JS API (Closed)

Created:
8 years ago by yoshiki
Modified:
8 years ago
CC:
chromium-reviews, Aaron Boodman, rginda+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Drive: Rename GData to Drive in extension JS API BUG=146981 TEST=compile, open Drive on Files.app, and open and copy a file in Drive. "Drive*" and "GData" in unit_test and browser_tests pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169868

Patch Set 1 #

Patch Set 2 : GDataFileProperties -> DriveFileProperties #

Patch Set 3 : pinGDataFile -> pinDriveFile #

Patch Set 4 : getGDataFiles -> getDriveFiles #

Patch Set 5 : searchGData -> searchDrive #

Patch Set 6 : Change 'gdata' to 'drive' of mount type. #

Total comments: 4

Patch Set 7 : review fix (comment #2) #

Total comments: 4

Patch Set 8 : rebase @169554 #

Patch Set 9 : review fix (comment #7) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -59 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.h View 1 2 3 4 5 6 7 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/directory_contents.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager_commands.js View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/metadata/metadata_cache.js View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/file_manager/js/volume_manager.js View 1 2 3 4 5 6 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/file_browser_private.json View 1 2 3 4 5 16 chunks +29 lines, -29 lines 0 comments Download
M chrome/renderer/resources/extensions/file_browser_private_custom_bindings.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/filebrowser_component/remote_search.js View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/cros_disks_client.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chromeos/disks/disk_mount_manager.cc View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
yoshiki
@satorux: could you take a first look?
8 years ago (2012-11-26 05:44:42 UTC) #1
satorux1
https://codereview.chromium.org/11414152/diff/7001/chrome/browser/resources/file_manager/js/volume_manager.js File chrome/browser/resources/file_manager/js/volume_manager.js (right): https://codereview.chromium.org/11414152/diff/7001/chrome/browser/resources/file_manager/js/volume_manager.js#newcode71 chrome/browser/resources/file_manager/js/volume_manager.js:71: }; Looks like a good cleanup, but I think ...
8 years ago (2012-11-26 05:50:40 UTC) #2
yoshiki
Thanks, PTAL https://codereview.chromium.org/11414152/diff/7001/chrome/browser/resources/file_manager/js/volume_manager.js File chrome/browser/resources/file_manager/js/volume_manager.js (right): https://codereview.chromium.org/11414152/diff/7001/chrome/browser/resources/file_manager/js/volume_manager.js#newcode71 chrome/browser/resources/file_manager/js/volume_manager.js:71: }; On 2012/11/26 05:50:40, satorux1 wrote: > ...
8 years ago (2012-11-26 06:07:22 UTC) #3
satorux1
LGTM. Adding other reviewers.
8 years ago (2012-11-26 07:18:08 UTC) #4
Vladislav Kaznacheev
On 2012/11/26 07:18:08, satorux1 wrote: > LGTM. Adding other reviewers. Replaced myself with dgozman@ in ...
8 years ago (2012-11-26 19:23:01 UTC) #5
tbarzic
lgtm
8 years ago (2012-11-26 19:28:51 UTC) #6
dgozman
LGTM Could you please file an issue to do the same rename in JS code? ...
8 years ago (2012-11-27 05:06:35 UTC) #7
yoshiki
> Could you please file an issue to do the same rename in JS code? ...
8 years ago (2012-11-27 07:58:59 UTC) #8
yoshiki
https://codereview.chromium.org/11414152/diff/2005/chrome/browser/resources/file_manager/js/metadata/metadata_cache.js File chrome/browser/resources/file_manager/js/metadata/metadata_cache.js (right): https://codereview.chromium.org/11414152/diff/2005/chrome/browser/resources/file_manager/js/metadata/metadata_cache.js#newcode705 chrome/browser/resources/file_manager/js/metadata/metadata_cache.js:705: * @param {DriveFileProperties} data GData file properties. On 2012/11/27 ...
8 years ago (2012-11-27 07:59:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11414152/8024
8 years ago (2012-11-27 07:59:35 UTC) #10
commit-bot: I haz the power
Presubmit check for 11414152-8024 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-11-27 07:59:50 UTC) #11
yoshiki
Adding other owners. Could you review following files? @asargent: chrome/renderer/resources/extensions/file_browser_private_custom_bindings.js @mkearney: chrome/common/extensions/api/file_browser_private.json
8 years ago (2012-11-27 08:05:21 UTC) #12
asargent_no_longer_on_chrome
Both chrome/renderer/resources/extensions/file_browser_private_custom_bindings.js chrome/common/extensions/api/file_browser_private.json LGTM (I'm in OWNERS for chrome/common/extensions/ too BTW)
8 years ago (2012-11-28 00:10:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11414152/8024
8 years ago (2012-11-28 01:46:50 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) aura_unit_tests
8 years ago (2012-11-28 03:39:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11414152/8024
8 years ago (2012-11-28 05:12:11 UTC) #16
commit-bot: I haz the power
8 years ago (2012-11-28 06:33:42 UTC) #17
Message was sent while issue was closed. 
Change committed as 169868

Powered by Google App Engine
This is Rietveld 408576698