Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 11414147: Add ability to create pending resource hosts. (Closed)

Created:
8 years ago by brettw
Modified:
8 years ago
Reviewers:
Tom Sepez, raymes
CC:
chromium-reviews
Visibility:
Public.

Description

Add ability to create pending resource hosts. Allows the host side to register a ResourceHost as pending and send an ID to the plugin, to be connected to a PluginResource at a future time. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171099

Patch Set 1 #

Patch Set 2 : Add notification #

Patch Set 3 : Assertion #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -1 line) Patch
M ppapi/host/ppapi_host.h View 1 2 3 4 5 3 chunks +13 lines, -0 lines 0 comments Download
M ppapi/host/ppapi_host.cc View 1 2 4 chunks +32 lines, -1 line 0 comments Download
M ppapi/host/resource_host.h View 1 2 chunks +15 lines, -0 lines 0 comments Download
M ppapi/host/resource_host.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M ppapi/proxy/plugin_resource.h View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M ppapi/proxy/plugin_resource.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
brettw
I didn't add a unit test for this since just the map lookup seemed silly ...
8 years ago (2012-12-03 00:44:59 UTC) #1
raymes
lgtm Looks good! https://codereview.chromium.org/11414147/diff/10002/ppapi/host/ppapi_host.h File ppapi/host/ppapi_host.h (right): https://codereview.chromium.org/11414147/diff/10002/ppapi/host/ppapi_host.h#newcode98 ppapi/host/ppapi_host.h:98: void OnHostMsgAttachToPendingHost(PP_Resource rseource, int pending_host_id); rseource->resource ...
8 years ago (2012-12-03 15:55:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/11414147/5002
8 years ago (2012-12-04 04:34:50 UTC) #3
commit-bot: I haz the power
Presubmit check for 11414147-5002 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-12-04 04:34:54 UTC) #4
brettw
Tom: fairly straightforward IPC review. Handler is implemented in ppapi_host.cc
8 years ago (2012-12-04 20:38:19 UTC) #5
Tom Sepez
LGTM on message security. Thanks.
8 years ago (2012-12-04 20:40:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/11414147/5002
8 years ago (2012-12-04 20:45:00 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-05 00:41:21 UTC) #8
Message was sent while issue was closed.
Change committed as 171099

Powered by Google App Engine
This is Rietveld 408576698