Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: verification/try_server.py

Issue 11414143: Change models.py to use typed class members instead of a list of strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/commit-queue
Patch Set: Address review comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « verification/try_job_on_rietveld.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: verification/try_server.py
diff --git a/verification/try_server.py b/verification/try_server.py
index ef704b7def409df05bd60ab50b8b50a421afbb56..a5d0ac5bca5f80e793c0aaf55bb5fa983c6b5897 100644
--- a/verification/try_server.py
+++ b/verification/try_server.py
@@ -72,24 +72,20 @@ class TryJob(model.PersistentMixIn):
TODO(maruel): Should use __getstate__(), __setstate__() and __reduce__().
"""
- persistent = [
- 'builder', 'build', 'revision', 'result', 'sent', 'failed_steps',
- 'clobber', 'name', 'tries', 'tests',
- ]
-
- def __init__(self, builder, tests, revision, clobber):
- super(TryJob, self).__init__()
- self.builder = builder
- self.build = None
- self.revision = revision
- self.result = None
- self.sent = time.time()
- self.failed_steps = []
- self.clobber = clobber
- self.name = None
- # Number of retries for this configuration.
- self.tries = 0
- self.tests = tests
+ builder = str
+ build = int
+ revision = (None, int)
+ result = (None, int)
+ sent = int
+ failed_steps = list
+ clobber = bool
+ name = (None, str)
+ # Number of retries for this configuration.
+ tries = int
+ tests = list
+
+ def __init__(self, **kwargs):
+ super(TryJob, self).__init__(sent=time.time(), **kwargs)
def get_state(self):
if self.result in (
@@ -105,16 +101,10 @@ class TryJob(model.PersistentMixIn):
class TryJobs(base.IVerifierStatus):
"""A set of try jobs that were sent for a specific patch."""
- persistent = base.IVerifierStatus.persistent + [
- 'try_jobs', 'skipped'
- ]
-
- def __init__(self):
- super(TryJobs, self).__init__()
- # An array of TryJob objects.
- self.try_jobs = []
- # When NOTRY=true is specified.
- self.skipped = False
+ # An array of TryJob objects.
+ try_jobs = list
+ # When NOTRY=true is specified.
+ skipped = bool
def get_state(self):
if self.skipped:
« no previous file with comments | « verification/try_job_on_rietveld.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698