verification/tree_status.py - Issue 11414143: Change models.py to use typed class members instead of a list of strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: verification/tree_status.py

Issue 11414143: Change models.py to use typed class members instead of a list of strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/commit-queue

Patch Set: Address review comments Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: verification/tree_status.py

diff --git a/verification/tree_status.py b/verification/tree_status.py

index d4bd78f048128aea41ca53f2e3f3543fe3dc7421..b258e16a88cdfbe4fb0f57fa0f230161d8812795 100644

--- a/verification/tree_status.py

+++ b/verification/tree_status.py

@@ -14,13 +14,7 @@ from verification import base

class TreeStatus(base.IVerifierStatus):

- persistent = base.IVerifierStatus.persistent + [

- 'tree_status_url',

- ]

- def __init__(self, tree_status_url):

- super(TreeStatus, self).__init__()

- self.tree_status_url = tree_status_url

+ tree_status_url = str

def get_state(self):

return base.SUCCEEDED

« no previous file with comments | « verification/base.py ('k') | verification/try_job_on_rietveld.py » ('j') | no next file with comments »