Change models.py to use typed class members instead of a list of strings.

pending_manager.py

 # coding=utf8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Commit queue manager class.
 
 Security implications:
 
 The following hypothesis are made:
 - Commit queue:
@@ skipping 13 matching lines @@
 import patch
 import subprocess2
 
 import errors
 import model
 from verification import base
 
 
 class PendingCommit(base.Verified):
   """Represents a pending commit that is being processed."""
-  persistent = base.Verified.persistent + [
-      # Important since they tell if we need to revalidate and send try jobs
-      # again or not if any of these value changes.
-      'issue', 'patchset', 'description', 'files',
-      # Only a cache, these values can be regenerated.
-      'owner', 'reviewers', 'base_url', 'messages', 'relpath',
-      # Only used after a patch was committed. Keeping here for try job retries.
-      'revision',
-  ]
+  # Important since they tell if we need to revalidate and send try jobs
+  # again or not if any of these value changes.
+  issue = int
+  patchset = int
+  description = unicode
+  files = list
+  # Only a cache, these values can be regenerated.
+  owner = str
+  reviewers = list
+  base_url = str
+  messages = list
+  relpath = str
+  # Only used after a patch was committed. Keeping here for try job retries.
+  revision = (None, int, str)
 
-  def __init__(
-      self, issue, owner, reviewers, patchset, base_url, description,
-      messages):
-    super(PendingCommit, self).__init__()
-    self.issue = issue
-    self.owner = owner
-    self.reviewers = reviewers
-    self.patchset = patchset
-    self.base_url = base_url
-    self.description = description
-    # Convert to unicode whenever necessary.
-    if isinstance(self.description, str):
-      self.description = self.description.decode('utf-8')
-    assert isinstance(self.description, unicode)
-    self.messages = messages
+  def __init__(self, description, **kwargs):
+    # Convert description to unicode whenever necessary.
+    if isinstance(description, str):
+      description = description.decode('utf-8')
+    super(PendingCommit, self).__init__(description=description, **kwargs)
     for message in self.messages:
       # Save storage, no verifier really need 'text', just 'approval'.
       if 'text' in message:
         del message['text']
-    self.revision = None
-    self.relpath = ''
-    self.files = []
 
   def pending_name(self):
     """The name that should be used for try jobs.
 
     It makes it possible to regenerate the try_jobs array if ever needed."""
     return '%d-%d' % (self.issue, self.patchset)
 
   def prepare_for_patch(self, context_obj):
     self.revision = context_obj.checkout.prepare(self.revision)
     # Verify revision consistency.
@@ skipping 27 matching lines @@
     except urllib2.HTTPError, e:
       raise base.DiscardPending(
           self,
           ('Failed to request the patch to try. Please note that binary files'
           'are still unsupported at the moment, this is being worked on.\n\n'
           'Thanks for your patience.\n\n%s') % e)
 
 
 class PendingQueue(model.PersistentMixIn):
   """Represents the queue of pending commits being processed."""
-  persistent = ['pending_commits']
-
-  def __init__(self):
-    super(PendingQueue, self).__init__()
-    self.pending_commits = []
+  pending_commits = list
 
 
 class PendingManager(object):
   """Fetch new issues from rietveld, pass the issues through all of verifiers
   and then commit the patches with checkout.
   """
   FAILED_NO_MESSAGE = (
       'Commit queue patch verification failed without an error message.\n'
       'Something went wrong, probably a crash, a hickup or simply\n'
       'the monkeys went out for dinner.\n'
@@ skipping 339 matching lines @@
 
   def load(self, filename):
     """Loads the commit queue state from a JSON file."""
     self.queue = model.load_from_json_file(filename)
     self.queue.pending_commits = self.queue.pending_commits or []
 
   def save(self, filename):
     """Save the commit queue state in a simple JSON file."""
     model.save_to_json_file(filename, self.queue)
     self.context.status.close()