Issue 11414140: [filemanager] Context menu command to pin/unpin file on Drive.

Issue 11414140: [filemanager] Context menu command to pin/unpin file on Drive. (Closed)

Created:
8 years, 1 month ago by dgozman

Modified:
8 years, 1 month ago

Reviewers:
SeRya, Dmitry Zvorygin

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[filemanager] Context menu command to pin/unpin file on Drive. BUG=131459 TEST=See bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169339

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -19 lines)			Patch
M	chrome/browser/resources/file_manager/css/file_manager.css	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1	3 chunks	+7 lines, -19 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager_commands.js	View	1	2 chunks	+62 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/main.html	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dmitry Zvorygin

LGTM with comment addressed. https://codereview.chromium.org/11414140/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://codereview.chromium.org/11414140/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode614 chrome/browser/resources/file_manager/js/file_manager.js:614: CommandUtil.registerCommand(doc, 'available-offline', Consider using verbs, ...

8 years, 1 month ago (2012-11-23 13:09:12 UTC) #2

dgozman

https://codereview.chromium.org/11414140/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://codereview.chromium.org/11414140/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode614 chrome/browser/resources/file_manager/js/file_manager.js:614: CommandUtil.registerCommand(doc, 'available-offline', On 2012/11/23 13:09:13, Dmitry Zvorygin wrote: > ...

8 years, 1 month ago (2012-11-23 13:13:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/11414140/3001

8 years, 1 month ago (2012-11-23 13:13:52 UTC) #4

Message was sent while issue was closed.

Change committed as 169339

Expand Messages | Collapse Messages