Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 11414127: fix the crash in QTMonitorImpl::Start() (Closed)

Created:
8 years, 1 month ago by no longer working on chromium
Modified:
8 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sail+watch_chromium.org
Visibility:
Public.

Description

It seems QTMonitorImpl::Start() crashed when getting the initial number of input devices in some conner cases. crash log: CMIOUnitCreateFromDescription CMIOUnitCreateFromDescription +[QTCaptureVDIGDevice _refreshDevices] +[QTCaptureVDIGDevice devicesWithIOType:] +[QTCaptureDevice devicesWithIOType:] +[QTCaptureDevice inputDevices] device_monitor_mac.mm:43] content::DeviceMonitorMac::QTMonitorImpl::Start I guess it is because some racing between chrome is launched and we enumerate the devices in QTMonitorImpl::Start(). A quick fix will be not to enumerate the devices in Start(), though this means that we will have to send one more device changed notification when a device is changed at the first time. BUG=162324 TEST=manual go to content settings and look at the the device lists. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169285

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M content/browser/device_monitor_mac.mm View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
no longer working on chromium
8 years, 1 month ago (2012-11-22 09:32:52 UTC) #1
Avi (use Gerrit)
:( lgtm
8 years, 1 month ago (2012-11-22 14:46:46 UTC) #2
no longer working on chromium
Thanks, I am not sure if this is completely safe, the stability of the device ...
8 years, 1 month ago (2012-11-22 15:08:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/11414127/1
8 years, 1 month ago (2012-11-22 15:08:44 UTC) #4
commit-bot: I haz the power
8 years, 1 month ago (2012-11-22 17:26:00 UTC) #5
Change committed as 169285

Powered by Google App Engine
This is Rietveld 408576698