Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 11413207: Add a 'filter' option to zip_build to allow for build post-processing. (Closed)

Created:
8 years ago by iannucci
Modified:
8 years ago
Reviewers:
nsylvain
CC:
chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org, M-A Ruel
Base URL:
http://git.chromium.org/chromium/tools/build.git@unit_test_refactor
Visibility:
Public.

Description

Add a 'filter' option to zip_build to allow for build post-processing. ASAN is the first filter. On windows, it will substitute in the .asan version in place of the original exe when building the zip file. R=nsylvain Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=170495

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use a single function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -6 lines) Patch
M scripts/common/chromium_utils.py View 1 4 chunks +14 lines, -3 lines 0 comments Download
M scripts/slave/zip_build.py View 1 5 chunks +36 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
iannucci
Cut out of https://chromiumcodereview.appspot.com/11379003/
8 years ago (2012-11-28 03:20:57 UTC) #1
nsylvain
LGTM, although I still think that we should just overwrite the files instead of creating ...
8 years ago (2012-11-28 18:55:52 UTC) #2
iannucci
https://chromiumcodereview.appspot.com/11413207/diff/1/scripts/common/chromium_utils.py File scripts/common/chromium_utils.py (right): https://chromiumcodereview.appspot.com/11413207/diff/1/scripts/common/chromium_utils.py#newcode537 scripts/common/chromium_utils.py:537: if new_src_path is None: On 2012/11/28 18:55:52, nsylvain wrote: ...
8 years ago (2012-11-29 02:19:12 UTC) #3
nsylvain
lgtm
8 years ago (2012-11-30 01:55:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/11413207/1003
8 years ago (2012-11-30 18:37:51 UTC) #5
commit-bot: I haz the power
8 years ago (2012-11-30 18:42:37 UTC) #6
Message was sent while issue was closed.
Change committed as 170495

Powered by Google App Engine
This is Rietveld 408576698