Refactored PPB_Flash GetSettings to the new pepper resource model

Refactored PPB_Flash GetSettings to the new pepper resource model

This also removes unnecessary code from the PluginDelegate and PepperMessageFilter.


BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173850

[dmichael (off chromium), 2012-12-13 17:39:00]

https://codereview.chromium.org/11413200/diff/42001/content/browser/renderer_...
File content/browser/renderer_host/pepper/pepper_flash_browser_host.cc (right):

https://codereview.chromium.org/11413200/diff/42001/content/browser/renderer_...
content/browser/renderer_host/pepper/pepper_flash_browser_host.cc:104:
AsWeakPtr(), context->MakeReplyMessageContext(),
Is this the only place you take advantage of SupportsWeakPtr? If so, it would be
better to just own a WeakPtrFactory. You don't want to expose AsWeakPtr if you
don't have to.

[raymes, 2012-12-14 17:43:53]

https://codereview.chromium.org/11413200/diff/42001/content/browser/renderer_...
File content/browser/renderer_host/pepper/pepper_flash_browser_host.cc (right):

https://codereview.chromium.org/11413200/diff/42001/content/browser/renderer_...
content/browser/renderer_host/pepper/pepper_flash_browser_host.cc:104:
AsWeakPtr(), context->MakeReplyMessageContext(),
On 2012/12/13 17:39:00, dmichael wrote:
> Is this the only place you take advantage of SupportsWeakPtr? If so, it would
be
> better to just own a WeakPtrFactory. You don't want to expose AsWeakPtr if you
> don't have to.

Done.

[dmichael (off chromium), 2012-12-15 00:06:08]

lgtm

[commit-bot: I haz the power, 2012-12-16 23:07:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/11413200/64001

[commit-bot: I haz the power, 2012-12-16 23:07:31]

Presubmit check for 11413200-64001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ppapi/proxy/ppapi_messages.h

Presubmit checks took 2.0s to calculate.

[raymes, 2012-12-16 23:08:20]

+tsepez for ppapi_messages

[Tom Sepez, 2012-12-17 21:28:31]

LGTM on messages.

[commit-bot: I haz the power, 2012-12-18 22:45:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/11413200/87001

[commit-bot: I haz the power, 2012-12-19 03:34:03]

Couldn't make sense out of svn commit message:
Sending        chrome/test/ppapi/ppapi_browsertest.cc
Sending        content/browser/renderer_host/pepper/pepper_flash_browser_host.cc
Sending        content/browser/renderer_host/pepper/pepper_flash_browser_host.h
Sending        content/browser/renderer_host/pepper/pepper_message_filter.cc
Sending        content/browser/renderer_host/pepper/pepper_message_filter.h
Sending        content/renderer/pepper/pepper_plugin_delegate_impl.cc
Sending        content/renderer/pepper/pepper_plugin_delegate_impl.h
Sending        ppapi/proxy/flash_resource.cc
Sending        ppapi/proxy/flash_resource.h
Sending        ppapi/proxy/ppapi_messages.h
Sending        ppapi/proxy/ppb_flash_proxy.cc
Sending        ppapi/proxy/ppb_flash_proxy.h
Sending        ppapi/proxy/ppb_instance_proxy.cc
Sending        ppapi/shared_impl/scoped_pp_var.h
Sending        ppapi/tests/test_flash.cc
Sending        ppapi/thunk/ppb_flash_api.h
Sending        ppapi/thunk/ppb_flash_functions_api.h
Sending        ppapi/thunk/ppb_flash_thunk.cc
Sending        webkit/plugins/ppapi/mock_plugin_delegate.cc
Sending        webkit/plugins/ppapi/mock_plugin_delegate.h
Sending        webkit/plugins/ppapi/plugin_delegate.h
Sending        webkit/plugins/ppapi/ppb_flash_impl.cc
Sending        webkit/plugins/ppapi/ppb_flash_impl.h
Transmitting file data .......................
Committed revision 173850.

Warning: post-commit hook failed (exit code 2) with output:
/opt/shared_hooks/post-commit.d/10_mailer.py:137: DeprecationWarning: The popen2
module is deprecated.  Use the subprocess module.
  import popen2
Post-commit mail timed out for r173850. Your commit succeeded,
but no mail was sent.