Issue 11413110: Don't specify -Wl,--exclude-libs=ALL for shared library build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11413110: Don't specify -Wl,--exclude-libs=ALL for shared library build. (Closed)

Created:
8 years, 1 month ago by Yaron

Modified:
8 years, 1 month ago

Reviewers:
nilesh, digit1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't specify -Wl,--exclude-libs=ALL for shared library build. This is used for normal builds to strip out lots of unneeded symbols and minimize binary size. However, for shared library build, this causes needed symbols to be excluded and subsequent so's to fail linking. BUG=158821 NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169060

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	build/common.gypi	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/11413110/1

8 years, 1 month ago (2012-11-21 16:27:36 UTC) #6

Change committed as 169060

Expand Messages | Collapse Messages